Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
The change is here https://github.com/apache/storm/pull/2805 and hasn't
been merged yet.
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2800
@srdo
Okey, i checkout the AtomicReference for jdk8 and get the code snippet:
```java
public final V getAndUpdate(UnaryOperator updateFunction) {
V prev, next;
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
@arunmahadevan yes, it make sense to use a LinkedList here. Thanks for the
explanation.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
@revans2 if I am not mistaken I recall that when you reviewed the initial
PR you suggested that a call to nextTuple should send only one tuple/record.
Can you please refresh my mind on the reasons why?
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2829
>what's the motivation to change this to LinkedList?
Its mentioned in the description. Heres the relevant code for some more
details -
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2829
@arunmahadevan what's the motivation to change this to LinkedList?
nextTuple emits only a single tuple because that's the contract of the
method nextTuple, which must be honored. This was
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2829
Also I am not sure why the nextTuple only emits a single tuple wheres
ideally it should emit whatever it can emit in a single nextTuple call which is
more efficient. However the logic appears
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2829
STORM-3222: Fix KafkaSpout internals to use LinkedList instead of ArrayList
KafkaSpout internally maintains a waitingToEmit list per topic partition
and keeps removing the first item to emit
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2823
---
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2789
what was the status of this? I think work @srdo was doing addressed
STORM-3173 possibly? Was that change committed?
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2828
https://user-images.githubusercontent.com/3441321/45451964-41d16800-b6a2-11e8-93b0-ed2b2239202c.png;>
This might need to be a separate JIRA, but there are a lot of missing
metrics on the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217175758
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1096,41 +1104,230 @@ public static String getWindowHint(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176198
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176027
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176251
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217175925
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176354
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176096
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176165
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176297
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217176395
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1540,6 +1737,37 @@ public static String getWorkerDumpLink(String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2828#discussion_r217175834
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -1096,41 +1104,230 @@ public static String getWindowHint(String
GitHub user govind-menon opened a pull request:
https://github.com/apache/storm/pull/2828
STORM-3217: Fixing getComponentPage API call
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/govind-menon/storm STORM-3217
Alternatively
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
@danny0405 Thanks for explaining. I'm not sure I understand why the
scheduling thread will see older values with `ConcurrentHashMap` than with
`AtomicReference`? It was my understanding that
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2827#discussion_r217094208
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ---
@@ -582,11 +582,9 @@ public static Response makeStandardResponse(
GitHub user govind-menon opened a pull request:
https://github.com/apache/storm/pull/2827
STORM-3221: Fixing utilization in clusterSummary API call
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/govind-menon/storm STORM-3221
Hi all,
There are some regressions that I introduced as part of STORM-1311 which
I'm working on as part of https://issues.apache.org/jira/browse/STORM-3217
and https://issues.apache.org/jira/browse/STORM-3221. These should be fixed
before a 2.x release
I have code working on the Yahoo internal
28 matches
Mail list logo
