[GitHub] [storm] srdo commented on issue #3004: Update Event Hubs spout and bolt to use modern Event Hubs client

2019-04-30 Thread GitBox
srdo commented on issue #3004: Update Event Hubs spout and bolt to use modern Event Hubs client URL: https://github.com/apache/storm/pull/3004#issuecomment-488216020 Hi, thanks for the patch. Upgrading the eventhubs client sounds good, but we need this to go in the newer branches first.

[GitHub] [storm] JamesBirdsall opened a new pull request #3004: Update Event Hubs spout and bolt to use modern Event Hubs client

2019-04-30 Thread GitBox
JamesBirdsall opened a new pull request #3004: Update Event Hubs spout and bolt to use modern Event Hubs client URL: https://github.com/apache/storm/pull/3004 We have customers using Storm 1.1.x, but the Event Hubs bolt and spout they were using was built from someone's private repo,

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Arun Mahadevan
+1 - Downloaded binaries - Brought up a local cluster - Ran a few topologies and checked the output and logs. If I just click on the "Owner" link from the UI, it displays a red banner with a warning. "This user's topologies are in danger of being unscheduled due to the owner's over-use of cluster

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Roshan Naik
Yes, you need to rebuild your topology jars against 2.0.  If you have some settings to tweak perf with 1.x,  refer to https://github.com/apache/storm/blob/master/docs/Performance.md for the 2.x configs. On Tuesday, April 30, 2019, 2:41:49 PM PDT, Alexandre Vermeerbergen wrote:

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Alexandre Vermeerbergen
Hello, I'm eager to test Storm 2.0.0 with my complex topologies, but first of all: do I need to rebuild all my topologies' Big Jars with Storm 2.0.0, or may I try my existing Storm 1.2.3 (recent snapshot)-based Big Jars ? Kind regards, Alexandre Vermeerbergen Le mar. 30 avr. 2019 à 00:49, P.

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Jungtaek Lim
+1 (binding) > source - verify file (MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 8 -- source, tar.gz : OK - build source dist -- source, tar.gz :

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Kishorkumar Patil
Built from the source code. All Unit tests passed. Ran some basic tests with WordCountTopology, BasicDRPCTopology. Run ThroughputVsLatency for comparison and it looks good- with 99.9% of events processed within 5.4ms. +1 On Tue, Apr 30, 2019 at 2:16 PM Derek Dagit wrote: > OK ran the

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Stig Rohde Døssing
+1 Ran tests from source zip Installed and ran ExclamationTopology on single-node cluster from binary zip Verified no unexpected error logs. Clicked around a bit in UI, verified that logviewer works. Checked out tag and ran the license check plugin to generate DEPENDENCY-LICENSES. Verified that

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Derek Dagit
OK ran the distribution from the tarball, and built and ran from the src tarball on macOS with JDK8. Tested WordCountTopology on both and it seemed fine. +1 On Tue, Apr 30, 2019 at 11:55 AM Derek Dagit wrote: > Sent too soon: > > - I verified sigs and sums > - Built the source from the tarball

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Derek Dagit
Sent too soon: - I verified sigs and sums - Built the source from the tarball on macOS - I saw a couple of test errors because the local stormconf.ser was gone when the supervisor tried to open it, and this resulted in a crash. I re-ran the tests and they passed. - I do not think this is a

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-04-30 Thread Derek Dagit
- I verified sigs and sums On Mon, Apr 29, 2019 at 5:49 PM P. Taylor Goetz wrote: > This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > > Full list of changes in this release: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > > The

[CANCELED] [VOTE] Release Apache Storm 1.2.4 (rc1)

2019-04-30 Thread P. Taylor Goetz
I accidentally skipped a version number. Will kick off a new RC tomorrow. -Taylor > On Apr 30, 2019, at 10:49 AM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.2.4 (rc1) > > Full list of changes in this release: > >

[VOTE] Release Apache Storm 1.2.4 (rc1)

2019-04-30 Thread P. Taylor Goetz
This is a call to vote on releasing Apache Storm 1.2.4 (rc1) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.4-rc1/RELEASE_NOTES.html The tag/commit to be voted upon is v1.2.4:

[GitHub] [storm] Ethanlm commented on a change in pull request #2997: [STORM-3380] Use Objects.equals to avoid possible NullPointerException

2019-04-30 Thread GitBox
Ethanlm commented on a change in pull request #2997: [STORM-3380] Use Objects.equals to avoid possible NullPointerException URL: https://github.com/apache/storm/pull/2997#discussion_r279756891 ## File path: storm-server/src/main/java/org/apache/storm/stats/StatsUtil.java

[GitHub] [storm] HeartSaVioR commented on a change in pull request #2997: [STORM-3380] Use Objects.equals to avoid possible NullPointerException

2019-04-30 Thread GitBox
HeartSaVioR commented on a change in pull request #2997: [STORM-3380] Use Objects.equals to avoid possible NullPointerException URL: https://github.com/apache/storm/pull/2997#discussion_r279683081 ## File path: storm-server/src/main/java/org/apache/storm/stats/StatsUtil.java