[GitHub] [storm] srdo commented on issue #3004: Update Event Hubs spout and bolt to use modern Event Hubs client
srdo commented on issue #3004: Update Event Hubs spout and bolt to use modern Event Hubs client URL: https://github.com/apache/storm/pull/3004#issuecomment-488216020 Hi, thanks for the patch. Upgrading the eventhubs client sounds good, but we need this to go in the newer branches first. The fix needs to go in master, and 1.x-branch, then we can decide whether we want it in 1.1.x as well. You can leave this PR open if you like, but we need separate PRs targeting those branches. Please also raise an issue at https://issues.apache.org/jira for this, and then rename the PR and commit messages to include the issue number. Ideally also squash to one commit, as that makes it easier for us to cherry pick fixes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] JamesBirdsall opened a new pull request #3004: Update Event Hubs spout and bolt to use modern Event Hubs client
JamesBirdsall opened a new pull request #3004: Update Event Hubs spout and bolt to use modern Event Hubs client URL: https://github.com/apache/storm/pull/3004 We have customers using Storm 1.1.x, but the Event Hubs bolt and spout they were using was built from someone's private repo, where they had rebuilt the bolt and spout to use the current Event Hubs client (artifact azure-eventhubs) instead of the old one (artifact eventhubs-client). This PR is intended to recover that codebase into the public Storm repo, and update it to the current version of azure-eventhubs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Storm 2.0.0 RC7
+1 - Downloaded binaries - Brought up a local cluster - Ran a few topologies and checked the output and logs. If I just click on the "Owner" link from the UI, it displays a red banner with a warning. "This user's topologies are in danger of being unscheduled due to the owner's over-use of cluster resources. Please keep this user's resource consumption within guaranteed bounds to ensure topologies for this user will continue to run." It just looks odd and I am not sure whats the criteria to decide if there is overuse. Looks like its displayed irrespective of the topology. Anyways I don't think its a blocker, something we could fix in the next release. Thanks, Arun On Tue, 30 Apr 2019 at 14:49, Roshan Naik wrote: > Yes, you need to rebuild your topology jars against 2.0. > If you have some settings to tweak perf with 1.x, refer to > https://github.com/apache/storm/blob/master/docs/Performance.md for the > 2.x configs. > > On Tuesday, April 30, 2019, 2:41:49 PM PDT, Alexandre Vermeerbergen < > avermeerber...@gmail.com> wrote: > > Hello, > > I'm eager to test Storm 2.0.0 with my complex topologies, but first of > all: do I need to rebuild all my topologies' Big Jars with Storm > 2.0.0, or may I try my existing Storm 1.2.3 (recent snapshot)-based > Big Jars ? > > Kind regards, > Alexandre Vermeerbergen > > Le mar. 30 avr. 2019 à 00:49, P. Taylor Goetz a écrit > : > > > > This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > > > > Full list of changes in this release: > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > > > > The tag/commit to be voted upon is v2.0.0: > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > > > > The source archive being voted upon can be found here: > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > > > > Other release files, signatures and digests can be found here: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > > > > The release artifacts are signed with the following key: > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > > > The Nexus staging repository for this release is: > > > > https://repository.apache.org/content/repositories/orgapachestorm-1079 > > > > Please vote on releasing this package as Apache Storm 2.0.0. > > > > When voting, please list the actions taken to verify the release. > > > > This vote will be open for at least 72 hours. > > > > [ ] +1 Release this package as Apache Storm 2.0.0 > > [ ] 0 No opinion > > [ ] -1 Do not release this package because... > > > > Thanks to everyone who contributed to this release. > > > > -Taylor
Re: [VOTE] Release Apache Storm 2.0.0 RC7
Yes, you need to rebuild your topology jars against 2.0. If you have some settings to tweak perf with 1.x, refer to https://github.com/apache/storm/blob/master/docs/Performance.md for the 2.x configs. On Tuesday, April 30, 2019, 2:41:49 PM PDT, Alexandre Vermeerbergen wrote: Hello, I'm eager to test Storm 2.0.0 with my complex topologies, but first of all: do I need to rebuild all my topologies' Big Jars with Storm 2.0.0, or may I try my existing Storm 1.2.3 (recent snapshot)-based Big Jars ? Kind regards, Alexandre Vermeerbergen Le mar. 30 avr. 2019 à 00:49, P. Taylor Goetz a écrit : > > This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > > Full list of changes in this release: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > > The tag/commit to be voted upon is v2.0.0: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > > The source archive being voted upon can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > > The release artifacts are signed with the following key: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1079 > > Please vote on releasing this package as Apache Storm 2.0.0. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 2.0.0 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor
Re: [VOTE] Release Apache Storm 2.0.0 RC7
Hello, I'm eager to test Storm 2.0.0 with my complex topologies, but first of all: do I need to rebuild all my topologies' Big Jars with Storm 2.0.0, or may I try my existing Storm 1.2.3 (recent snapshot)-based Big Jars ? Kind regards, Alexandre Vermeerbergen Le mar. 30 avr. 2019 à 00:49, P. Taylor Goetz a écrit : > > This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > > Full list of changes in this release: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > > The tag/commit to be voted upon is v2.0.0: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > > The source archive being voted upon can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > > The release artifacts are signed with the following key: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1079 > > Please vote on releasing this package as Apache Storm 2.0.0. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 2.0.0 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor
Re: [VOTE] Release Apache Storm 2.0.0 RC7
+1 (binding) > source - verify file (MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 8 -- source, tar.gz : OK - build source dist -- source, tar.gz : OK - build binary dist -- source, tar.gz : OK > binary - verify file (MD5, SHA) -- binary, tar.gz : OK -- binary, zip : OK - extract file -- binary, tar.gz : OK -- binary, zip : OK - diff-ing extracted files between tar.gz and zip : OK - launch daemons : OK - run ExclamationTopology (local) : OK - run RollingTopWords (remote) : OK - activate / deactivate / rebalance / kill : OK - logviewer (worker dir, daemon dir) : OK - change log level : OK - thread dump, heap dump, restart worker : OK - log search : OK Thanks, Jungtaek Lim (HeartSaVioR) On Wed, May 1, 2019 at 4:38 AM Kishorkumar Patil wrote: > Built from the source code. All Unit tests passed. > Ran some basic tests with WordCountTopology, BasicDRPCTopology. > Run ThroughputVsLatency for comparison and it looks good- with 99.9% of > events processed within 5.4ms. > +1 > > > On Tue, Apr 30, 2019 at 2:16 PM Derek Dagit > wrote: > > > OK ran the distribution from the tarball, and built and ran from the src > > tarball on macOS with JDK8. Tested WordCountTopology on both and it > seemed > > fine. > > > > +1 > > > > On Tue, Apr 30, 2019 at 11:55 AM Derek Dagit wrote: > > > > > Sent too soon: > > > > > > - I verified sigs and sums > > > - Built the source from the tarball on macOS > > > - I saw a couple of test errors because the local stormconf.ser was > > gone > > > when the supervisor tried to open it, and this resulted in a crash. I > > > re-ran the tests and they passed. > > > - I do not think this is a blocker, but it is probable worth looking > > > into. > > > > > > I'll continue to evaluate the RC, but wanted to send this out in case > > > anyone else has seen something similar. > > > > > > On Tue, Apr 30, 2019 at 11:52 AM Derek Dagit wrote: > > > > > >> - I verified sigs and sums > > >> > > >> On Mon, Apr 29, 2019 at 5:49 PM P. Taylor Goetz > > >> wrote: > > >> > > >>> This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > > >>> > > >>> Full list of changes in this release: > > >>> > > >>> > > >>> > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > > >>> > > >>> The tag/commit to be voted upon is v2.0.0: > > >>> > > >>> > > >>> > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > > >>> > > >>> The source archive being voted upon can be found here: > > >>> > > >>> > > >>> > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > > >>> > > >>> Other release files, signatures and digests can be found here: > > >>> > > >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > > >>> > > >>> The release artifacts are signed with the following key: > > >>> > > >>> > > >>> > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > >>> > > >>> The Nexus staging repository for this release is: > > >>> > > >>> > https://repository.apache.org/content/repositories/orgapachestorm-1079 > > >>> > > >>> Please vote on releasing this package as Apache Storm 2.0.0. > > >>> > > >>> When voting, please list the actions taken to verify the release. > > >>> > > >>> This vote will be open for at least 72 hours. > > >>> > > >>> [ ] +1 Release this package as Apache Storm 2.0.0 > > >>> [ ] 0 No opinion > > >>> [ ] -1 Do not release this package because... > > >>> > > >>> Thanks to everyone who contributed to this release. > > >>> > > >>> -Taylor > > >> > > >> > > > -- Name : Jungtaek Lim Blog : http://medium.com/@heartsavior Twitter : http://twitter.com/heartsavior LinkedIn : http://www.linkedin.com/in/heartsavior
Re: [VOTE] Release Apache Storm 2.0.0 RC7
Built from the source code. All Unit tests passed. Ran some basic tests with WordCountTopology, BasicDRPCTopology. Run ThroughputVsLatency for comparison and it looks good- with 99.9% of events processed within 5.4ms. +1 On Tue, Apr 30, 2019 at 2:16 PM Derek Dagit wrote: > OK ran the distribution from the tarball, and built and ran from the src > tarball on macOS with JDK8. Tested WordCountTopology on both and it seemed > fine. > > +1 > > On Tue, Apr 30, 2019 at 11:55 AM Derek Dagit wrote: > > > Sent too soon: > > > > - I verified sigs and sums > > - Built the source from the tarball on macOS > > - I saw a couple of test errors because the local stormconf.ser was > gone > > when the supervisor tried to open it, and this resulted in a crash. I > > re-ran the tests and they passed. > > - I do not think this is a blocker, but it is probable worth looking > > into. > > > > I'll continue to evaluate the RC, but wanted to send this out in case > > anyone else has seen something similar. > > > > On Tue, Apr 30, 2019 at 11:52 AM Derek Dagit wrote: > > > >> - I verified sigs and sums > >> > >> On Mon, Apr 29, 2019 at 5:49 PM P. Taylor Goetz > >> wrote: > >> > >>> This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > >>> > >>> Full list of changes in this release: > >>> > >>> > >>> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > >>> > >>> The tag/commit to be voted upon is v2.0.0: > >>> > >>> > >>> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > >>> > >>> The source archive being voted upon can be found here: > >>> > >>> > >>> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > >>> > >>> Other release files, signatures and digests can be found here: > >>> > >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > >>> > >>> The release artifacts are signed with the following key: > >>> > >>> > >>> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > >>> > >>> The Nexus staging repository for this release is: > >>> > >>> https://repository.apache.org/content/repositories/orgapachestorm-1079 > >>> > >>> Please vote on releasing this package as Apache Storm 2.0.0. > >>> > >>> When voting, please list the actions taken to verify the release. > >>> > >>> This vote will be open for at least 72 hours. > >>> > >>> [ ] +1 Release this package as Apache Storm 2.0.0 > >>> [ ] 0 No opinion > >>> [ ] -1 Do not release this package because... > >>> > >>> Thanks to everyone who contributed to this release. > >>> > >>> -Taylor > >> > >> >
Re: [VOTE] Release Apache Storm 2.0.0 RC7
+1 Ran tests from source zip Installed and ran ExclamationTopology on single-node cluster from binary zip Verified no unexpected error logs. Clicked around a bit in UI, verified that logviewer works. Checked out tag and ran the license check plugin to generate DEPENDENCY-LICENSES. Verified that there are no category X licenses. A number of dependency versions have changed, but I don't think this should block the release. I'll see if we can automate generating the license files a bit more, so we don't forget to update them. Derek, I'm not sure about a missing stormconf.ser, but there are a couple of open issues impacting tests stability. See https://issues.apache.org/jira/browse/STORM-3376 and https://issues.apache.org/jira/browse/STORM-3379. Maybe one of them fixes it? I've run the integration test and localcluster tests a bunch of times with these fixes, and the tests looks stable to me. If you get the errors occasionally, it would be nice if you could see if they are still there when applying the two fixes. Den tir. 30. apr. 2019 kl. 20.16 skrev Derek Dagit : > OK ran the distribution from the tarball, and built and ran from the src > tarball on macOS with JDK8. Tested WordCountTopology on both and it seemed > fine. > > +1 > > On Tue, Apr 30, 2019 at 11:55 AM Derek Dagit wrote: > > > Sent too soon: > > > > - I verified sigs and sums > > - Built the source from the tarball on macOS > > - I saw a couple of test errors because the local stormconf.ser was > gone > > when the supervisor tried to open it, and this resulted in a crash. I > > re-ran the tests and they passed. > > - I do not think this is a blocker, but it is probable worth looking > > into. > > > > I'll continue to evaluate the RC, but wanted to send this out in case > > anyone else has seen something similar. > > > > On Tue, Apr 30, 2019 at 11:52 AM Derek Dagit wrote: > > > >> - I verified sigs and sums > >> > >> On Mon, Apr 29, 2019 at 5:49 PM P. Taylor Goetz > >> wrote: > >> > >>> This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > >>> > >>> Full list of changes in this release: > >>> > >>> > >>> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > >>> > >>> The tag/commit to be voted upon is v2.0.0: > >>> > >>> > >>> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > >>> > >>> The source archive being voted upon can be found here: > >>> > >>> > >>> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > >>> > >>> Other release files, signatures and digests can be found here: > >>> > >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > >>> > >>> The release artifacts are signed with the following key: > >>> > >>> > >>> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > >>> > >>> The Nexus staging repository for this release is: > >>> > >>> https://repository.apache.org/content/repositories/orgapachestorm-1079 > >>> > >>> Please vote on releasing this package as Apache Storm 2.0.0. > >>> > >>> When voting, please list the actions taken to verify the release. > >>> > >>> This vote will be open for at least 72 hours. > >>> > >>> [ ] +1 Release this package as Apache Storm 2.0.0 > >>> [ ] 0 No opinion > >>> [ ] -1 Do not release this package because... > >>> > >>> Thanks to everyone who contributed to this release. > >>> > >>> -Taylor > >> > >> >
Re: [VOTE] Release Apache Storm 2.0.0 RC7
OK ran the distribution from the tarball, and built and ran from the src tarball on macOS with JDK8. Tested WordCountTopology on both and it seemed fine. +1 On Tue, Apr 30, 2019 at 11:55 AM Derek Dagit wrote: > Sent too soon: > > - I verified sigs and sums > - Built the source from the tarball on macOS > - I saw a couple of test errors because the local stormconf.ser was gone > when the supervisor tried to open it, and this resulted in a crash. I > re-ran the tests and they passed. > - I do not think this is a blocker, but it is probable worth looking > into. > > I'll continue to evaluate the RC, but wanted to send this out in case > anyone else has seen something similar. > > On Tue, Apr 30, 2019 at 11:52 AM Derek Dagit wrote: > >> - I verified sigs and sums >> >> On Mon, Apr 29, 2019 at 5:49 PM P. Taylor Goetz >> wrote: >> >>> This is a call to vote on releasing Apache Storm 2.0.0 (rc7) >>> >>> Full list of changes in this release: >>> >>> >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html >>> >>> The tag/commit to be voted upon is v2.0.0: >>> >>> >>> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae >>> >>> The source archive being voted upon can be found here: >>> >>> >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz >>> >>> Other release files, signatures and digests can be found here: >>> >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ >>> >>> The release artifacts are signed with the following key: >>> >>> >>> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >>> >>> The Nexus staging repository for this release is: >>> >>> https://repository.apache.org/content/repositories/orgapachestorm-1079 >>> >>> Please vote on releasing this package as Apache Storm 2.0.0. >>> >>> When voting, please list the actions taken to verify the release. >>> >>> This vote will be open for at least 72 hours. >>> >>> [ ] +1 Release this package as Apache Storm 2.0.0 >>> [ ] 0 No opinion >>> [ ] -1 Do not release this package because... >>> >>> Thanks to everyone who contributed to this release. >>> >>> -Taylor >> >>
Re: [VOTE] Release Apache Storm 2.0.0 RC7
Sent too soon: - I verified sigs and sums - Built the source from the tarball on macOS - I saw a couple of test errors because the local stormconf.ser was gone when the supervisor tried to open it, and this resulted in a crash. I re-ran the tests and they passed. - I do not think this is a blocker, but it is probable worth looking into. I'll continue to evaluate the RC, but wanted to send this out in case anyone else has seen something similar. On Tue, Apr 30, 2019 at 11:52 AM Derek Dagit wrote: > - I verified sigs and sums > > On Mon, Apr 29, 2019 at 5:49 PM P. Taylor Goetz wrote: > >> This is a call to vote on releasing Apache Storm 2.0.0 (rc7) >> >> Full list of changes in this release: >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html >> >> The tag/commit to be voted upon is v2.0.0: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae >> >> The source archive being voted upon can be found here: >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz >> >> Other release files, signatures and digests can be found here: >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ >> >> The release artifacts are signed with the following key: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >> >> The Nexus staging repository for this release is: >> >> https://repository.apache.org/content/repositories/orgapachestorm-1079 >> >> Please vote on releasing this package as Apache Storm 2.0.0. >> >> When voting, please list the actions taken to verify the release. >> >> This vote will be open for at least 72 hours. >> >> [ ] +1 Release this package as Apache Storm 2.0.0 >> [ ] 0 No opinion >> [ ] -1 Do not release this package because... >> >> Thanks to everyone who contributed to this release. >> >> -Taylor > >
Re: [VOTE] Release Apache Storm 2.0.0 RC7
- I verified sigs and sums On Mon, Apr 29, 2019 at 5:49 PM P. Taylor Goetz wrote: > This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > > Full list of changes in this release: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > > The tag/commit to be voted upon is v2.0.0: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > > The source archive being voted upon can be found here: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > > The release artifacts are signed with the following key: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1079 > > Please vote on releasing this package as Apache Storm 2.0.0. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 2.0.0 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor
[CANCELED] [VOTE] Release Apache Storm 1.2.4 (rc1)
I accidentally skipped a version number. Will kick off a new RC tomorrow. -Taylor > On Apr 30, 2019, at 10:49 AM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.2.4 (rc1) > > Full list of changes in this release: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.4-rc1/RELEASE_NOTES.html > > The tag/commit to be voted upon is v1.2.4: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=47cd68feb442a80abd40f0942baaed899c14ee66;hb=8143f448849a266a90ae4d4f5cc1c12c5f8e5188 > > The source archive being voted upon can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.4-rc1/apache-storm-1.2.4-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.4-rc1/ > > The release artifacts are signed with the following key: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1080 > > Please vote on releasing this package as Apache Storm 1.2.4. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 1.2.4 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor
[VOTE] Release Apache Storm 1.2.4 (rc1)
This is a call to vote on releasing Apache Storm 1.2.4 (rc1) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.4-rc1/RELEASE_NOTES.html The tag/commit to be voted upon is v1.2.4: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=47cd68feb442a80abd40f0942baaed899c14ee66;hb=8143f448849a266a90ae4d4f5cc1c12c5f8e5188 The source archive being voted upon can be found here: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.4-rc1/apache-storm-1.2.4-src.tar.gz Other release files, signatures and digests can be found here: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.4-rc1/ The release artifacts are signed with the following key: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd The Nexus staging repository for this release is: https://repository.apache.org/content/repositories/orgapachestorm-1080 Please vote on releasing this package as Apache Storm 1.2.4. When voting, please list the actions taken to verify the release. This vote will be open for at least 72 hours. [ ] +1 Release this package as Apache Storm 1.2.4 [ ] 0 No opinion [ ] -1 Do not release this package because... Thanks to everyone who contributed to this release. -Taylor
[GitHub] [storm] Ethanlm commented on a change in pull request #2997: [STORM-3380] Use Objects.equals to avoid possible NullPointerException
Ethanlm commented on a change in pull request #2997: [STORM-3380] Use
Objects.equals to avoid possible NullPointerException
URL: https://github.com/apache/storm/pull/2997#discussion_r279756891
##
File path: storm-server/src/main/java/org/apache/storm/stats/StatsUtil.java
##
@@ -2004,7 +2005,7 @@ private static ComponentPageInfo thriftifyCompPageData(
win2stats.put(FAILED, ClientStatsUtil.getMapByKey(data,
WIN_TO_FAILED));
String compType = (String) data.get(TYPE);
-if (compType.equals(ClientStatsUtil.SPOUT)) {
+if (Objects.equals(compType,ClientStatsUtil.SPOUT)) {
Review comment:
I agree. Maybe also consider throwing exceptions if it will ever be null.
Need to understand it more
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] HeartSaVioR commented on a change in pull request #2997: [STORM-3380] Use Objects.equals to avoid possible NullPointerException
HeartSaVioR commented on a change in pull request #2997: [STORM-3380] Use
Objects.equals to avoid possible NullPointerException
URL: https://github.com/apache/storm/pull/2997#discussion_r279683081
##
File path: storm-server/src/main/java/org/apache/storm/stats/StatsUtil.java
##
@@ -2004,7 +2005,7 @@ private static ComponentPageInfo thriftifyCompPageData(
win2stats.put(FAILED, ClientStatsUtil.getMapByKey(data,
WIN_TO_FAILED));
String compType = (String) data.get(TYPE);
-if (compType.equals(ClientStatsUtil.SPOUT)) {
+if (Objects.equals(compType,ClientStatsUtil.SPOUT)) {
Review comment:
It looks like only avoiding NPE, which also makes misleading as component
being interpreted as bolt. We should see what are the actual cases of
`data.get(TYPE)` being null, and decide how to fix based on the case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
