[GitHub] storm pull request: [STORM-569] Add Configuration to enable/disabl...

2014-11-21 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/324 [STORM-569] Add Configuration to enable/disable Bolt's outgoing overflow-buffer - Added topology level flag `topology.bolts.outgoing.overflow.buffer.enable` - which defaults to `true

[GitHub] storm pull request: [STORM-400] Thrift upgrade to thrift-0.9.2

2015-02-02 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/410 [STORM-400] Thrift upgrade to thrift-0.9.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishorvpatil/incubator-storm thrift092

[GitHub] storm pull request: [STORM-400] Thrift upgrade to thrift-0.9.2

2015-02-05 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/410#issuecomment-73174063 @ptgoetz, Thanks for reviewing this. I have up merged the changes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: [STORM-400] Thrift upgrade to thrift-0.9.2

2015-02-17 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/410#issuecomment-74700449 @darionyaphet, Thrift 0.9.2 includes python hash function. [https://issues.apache.org/jira/browse/THRIFT-2621]. Without this change, we were using @nathanmarz 's

[GitHub] storm pull request: update supervisor.clj add a comment to supervi...

2015-01-30 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/258#issuecomment-72265757 @BuDongDong, can you please create JIRA to elaborate on the change, and need to delete missing-tasks? Also it would be good to get PR subject describe changes

[GitHub] storm pull request: [STORM-653] missing DRPC HTTP port in SECURITY...

2015-02-09 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/413#issuecomment-73544830 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-18 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/468 [STORM-712] Storm daemons shutdown if OutOfMemoryError occurs in any thread - Creating `ExtendedThreadPoolExecutor` to pass uncaughtExceptions as part of `afterExecute` - All daemon main

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2015-03-19 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-83749375 @revans2 Thank you. I have merged in the changes. Sorry for delay. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-682: supervisor should handle worker sta...

2015-03-02 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/437#issuecomment-76751433 Looks good. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: STORM-532:Supervisor should restart worker imm...

2015-03-02 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/296#issuecomment-76745378 @caofangkun, could you please upmerge this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: [STORM-557] Created docs directory and added i...

2015-03-02 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/314#issuecomment-76749927 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-563. Kafka Spout doesn't pick up from th...

2015-02-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/321#issuecomment-75573879 @harshach would you like to provide update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-27 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/468#discussion_r27318086 --- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java --- @@ -533,4 +533,16 @@ private static SerializationDelegate getSerializationDelegate(Map

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-27 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/468#discussion_r27317843 --- Diff: storm-core/src/jvm/backtype/storm/drpc/DRPCSpout.java --- @@ -129,7 +133,9 @@ private void checkFutures() { public void open(Map conf

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-25 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/468#issuecomment-86350235 @lazyval, sorry for delay in responding. We have seen this happen in case some of our clusters. When the `ExecutorService`, executes the `FutureTask`, it captures

[GitHub] storm pull request: STORM-797: DisruptorQueueTest has some race co...

2015-04-28 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/537#issuecomment-97092233 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-04-08 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/468#issuecomment-91057918 @lazyval Thanks for pointing out. I have updated the PR to rethrow non OOM Errors. Also, main server thread should exit on Error. --- If your project is set up

[GitHub] storm pull request: STORM-750: Set Config serialVersionUID

2015-04-06 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/507#issuecomment-90160883 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-848] Shade external dependencies

2015-06-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/577#issuecomment-109056014 Thank you @ptgoetz. The changes worked. And Jetty is shaded now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: [STORM-848] Shade external dependencies

2015-06-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/577#issuecomment-109043828 I tried What @Parth-Brahmbhatt suggested to successfully build it. Testing it now. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: [STORM-848] Shade external dependencies

2015-06-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/577#issuecomment-108989857 @Parth-Brahmbhatt Primarily, anything that's getting directly called from withing clojure is hard to shade. Hence (disruptor, jetty..) etc are not shaded

[GitHub] storm pull request: STORM-853 Fix upload API to handle multi-args ...

2015-06-08 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/581#issuecomment-110025014 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-848] Shade external dependencies

2015-06-04 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/577 [STORM-848] Shade external dependencies Shading following dependencies: org.apache.httpcomponents:http* org.apache.zookeeper:zookeeper org.apache.curator:* com.twitter:carbonite

[GitHub] storm pull request: [STORM-848] Shade external dependencies

2015-06-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/577#issuecomment-109023252 @ptgoetz I get following exceptions when I try to shade Jetty ```Console Compiling storm.starter.clj.word-count to /home/kpatil/commun/incubator-storm

[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME

2015-06-09 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/457#issuecomment-110489805 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-477] Add warning for invalid JAVA_HOME

2015-06-26 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/457#issuecomment-115756416 @ppoulosk Thank you for the patch. This is merged into the master now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-864 Exclude storm-kafka tests from Travi...

2015-06-15 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/591#issuecomment-112089001 Thank you @HeartSaVioR. I have merged the change in. This should help us get better feedback on the pull request from CI build. --- If your project is set up

[GitHub] storm pull request: STORM-860 disable Activate button when topol...

2015-06-15 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/590#issuecomment-112094414 Thank you @HeartSaVioR . This change is merged to master now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: [STORM-874] Add UncaughtExceptionHandler for n...

2015-06-17 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/597 [STORM-874] Add UncaughtExceptionHandler for netty threads The netty threads need to handle uncaught exceptions. This would help ensure that JVM exits if netty threads hit OOM Error while

[GitHub] storm pull request: STORM-847 Adding new cli for getting latest er...

2015-06-12 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/576#issuecomment-111516456 Thank you @snikhil5. This is pulled into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-866: Use storm.log.dir instead of storm....

2015-06-12 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/592#issuecomment-111503147 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-864 Exclude storm-kafka tests from Travi...

2015-06-12 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/591#issuecomment-111580559 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-860 disable Activate button when topol...

2015-06-12 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/590#issuecomment-111583986 +1. Good catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...

2015-05-27 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/559#issuecomment-106066678 @ptgoetz Thank you for the feedback. I will rename the config o `UI_PROJECT_BUGTRACKER_URL`. Find licensed images and add documentation to the this PR

[GitHub] storm pull request: [STORM-833] Logging framework logback - log4j...

2015-05-22 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/562 [STORM-833] Logging framework logback - log4j 2.x As part of changes to logging framework: - Migrate from logback to log4j2 - Use RFC5424 foramt for routing logs to rsyslog - Get

[GitHub] storm pull request: STORM-1128: Make metrics fast

2015-10-24 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/816#issuecomment-150853651 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1125] Adding separate ZK client for rea...

2015-10-22 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/813#discussion_r42795412 --- Diff: storm-core/src/clj/backtype/storm/cluster.clj --- @@ -89,68 +107,69 @@ (set-ephemeral-node [this path data acls

[GitHub] storm pull request: [STORM-1125] Adding separate ZK client for rea...

2015-10-22 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/813 [STORM-1125] Adding separate ZK client for read in Nimbus ZK State Separate reader and writer for nimbus to avoid longer waits for reads to finish. You can merge this pull request into a Git

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/810 [STORM-1121] Remove method call to avoid overhead during topology submission time Nimbus calls mk-assignments from SubmitTopology within lock is causing it to wait for processing of all

[GitHub] storm pull request: Fixed incubator URLs

2015-10-29 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/828#discussion_r43389985 --- Diff: docs/documentation/Message-passing-implementation.md --- @@ -8,23 +8,23 @@ documentation: true This page walks through how emitting

[GitHub] storm pull request: Fixed incubator URLs

2015-10-29 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/828#discussion_r43390007 --- Diff: docs/documentation/Message-passing-implementation.md --- @@ -8,23 +8,23 @@ documentation: true This page walks through how emitting

[GitHub] storm pull request: Fixed incubator URLs

2015-10-29 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/828#discussion_r43390022 --- Diff: docs/documentation/Message-passing-implementation.md --- @@ -8,23 +8,23 @@ documentation: true This page walks through how emitting

[GitHub] storm pull request: STORM-350: Upgrade to newer version of disrupt...

2015-10-28 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/797#issuecomment-151863878 Thanks @HeartSaVioR @harshach. I will pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-29 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/829#issuecomment-152308917 LGTM. The 1.8 travis build failure seems unrelated. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: Disruptor batching v2

2015-10-28 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/765#issuecomment-151942417 @d2r @knusbaum @mjsax @harshach @HeartSaVioR @ptgoetz Now that #797 is in. We should consider pulling in batching solution. Can you please review this PR

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150667453 @HeartSaVioR Thank you for review and suggestions. I have made changes so that our tests are using simulated-time cluster to avoid `Thread/sleep`. Please revisit

[GitHub] storm pull request: STORM-350: Upgrade to newer version of disrupt...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/797#issuecomment-150673459 LGTM. +1. @HeartSaVioR would you like to revisit and see Bobby's changes have addressed you comment. We have been running this in our staging for some time now

[GitHub] storm pull request: [STORM-1125] Adding separate ZK client for rea...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/813#issuecomment-150674032 @HeartSaVioR I have updated the the code to use flag instead of is-nimbus? method. Thank you for suggesting this loose-coupling. Please revisit the changes

[GitHub] storm pull request: STORM-350: Upgrade to newer version of disrupt...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/797#issuecomment-150698673 @HeartSaVioR We are not seeing any tuple loss, so there as way can we reproduce it? Some details on what topology, cluster setup and/or h/w to help us reproduce

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150703213 @HeartSaVioR I don't think we can remove `NIMBUS-REASSIGN` as it used mostly during supervisor_test to avoid rescheduling with value `false`. The documentation

[GitHub] storm pull request: [Storm-1121] Deprecate test only configuraton ...

2015-10-23 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/815 [Storm-1121] Deprecate test only configuraton nimbus.reassign You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishorvpatil/incubator-storm

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150729673 @HeartSaVioR - Modified to make "nimbus.reassign" unavailable for users. - Created #815 to decommission variable for 0.10.x branch. -

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150702270 @HeartSaVioR Removed rebalance calls at places where I could use simulated time cluster. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150699962 @HeartSaVioR I tried that for supervisor_test.clj, somehow mocking of submit topologies etc.methods don't make it easy. It seems straight forward to rebalance

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-23 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150711148 @HeartSaVioR I complete agree with decommissioning this configuration used only for testing. It should be unavailable for users. Let me deprecate this variable

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150049582 @HeartSaVioR looking into compilation issue. Somehow it did not get committed. Re-running the build. --- If your project is set up for it, you can reply

[GitHub] storm pull request: STORM-1196: Upgrade to thrift 0.9.3

2015-11-11 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/873#issuecomment-155829362 +1. This would simplify a lot of pull requests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-1191: bump timeout by 50% due to intermi...

2015-11-09 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/869#issuecomment-155146265 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: Add codota search for apache/storm to Readme

2015-11-09 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/781#issuecomment-155093941 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1145: Have IConnection push tuples inste...

2015-11-09 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/830#issuecomment-155104855 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1189: Maintain wire compatability with 0...

2015-11-09 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/868#issuecomment-155093325 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...

2015-11-13 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/559#issuecomment-156562230 @ptgoetz and @revans2 Added MIT license to both LICENSE files. Thanks again for reviewing this. --- If your project is set up for it, you can reply

[GitHub] storm pull request: [STORM-1204] Fixing attempt to access to direc...

2015-11-16 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/879#issuecomment-157097910 @redsanket We are doing this only are couple of places.. no making it a utility may not be much useful. --- If your project is set up for it, you can reply

[GitHub] storm pull request: [STORM-1208] Guard against NPE, and avoid usin...

2015-11-16 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/881#issuecomment-157164426 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...

2015-11-12 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/559#issuecomment-156167438 https://cloud.githubusercontent.com/assets/6090397/11124983/22c5ab24-892d-11e5-8361-fe037943b23c.png;> --- If your project is set up for it, you can re

[GitHub] storm pull request: [STORM-831] Adding jira and central logging li...

2015-11-12 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/559#issuecomment-156168075 @revans2 @ptgoetz Sorry for the delay in fixing this. - I updated config name to `UI_PROJECT_BUGTRACKER_URL`. - The new images are from public domain

[GitHub] storm pull request: STORM-1190: System Load too high after recent ...

2015-11-12 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/870#issuecomment-156196285 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1215] Use Asynchronous logger for impro...

2015-11-17 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/888 [STORM-1215] Use Asynchronous logger for improving performance. The changes to loggers for all daemons and workers. - Turn off immediateFlush. - Enable async logging. - Turn off

[GitHub] storm pull request: [STORM-1157] Adding dynamic profiling for work...

2015-11-02 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/842#issuecomment-153258132 Currently, this feature lacks support for windows and command-line interface. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: [STORM-1157] Adding dynamic profiling for work...

2015-11-02 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/842 [STORM-1157] Adding dynamic profiling for worker, restarting worker, jstack, heap dump, and profiling - Request restarting worker. - Request jstack, - Request heap dump, - Start

[GitHub] storm pull request: [STORM-1157] Adding dynamic profiling for work...

2015-11-02 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/842#issuecomment-153258716 https://cloud.githubusercontent.com/assets/6090397/10902398/ec51a46a-81c2-11e5-92f5-d4c79d0b80df.png;> https://cloud.githubusercontent.com/assets/6090397/10902

[GitHub] storm pull request: [STORM-1170] Fix the producer alive issue in D...

2015-11-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/859#issuecomment-153882993 LGTM. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43813101 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -1103,21 +1216,39 @@ (.set_reset_log_level_timeout_epoch log-config (coerce

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43813189 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -1179,13 +1312,15 @@ (fn

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43815176 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -440,10 +442,78 @@ (shutdown-worker supervisor id

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821581 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java --- @@ -0,0 +1,278 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821476 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/FileBlobStoreImpl.java --- @@ -0,0 +1,241 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821497 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/HdfsBlobStore.java --- @@ -0,0 +1,369 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821520 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/HdfsClientBlobStore.java --- @@ -0,0 +1,105 @@ +package backtype.storm.blobstore

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821482 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/HdfsBlobStore.java --- @@ -0,0 +1,369 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821236 --- Diff: storm-core/src/jvm/backtype/storm/ConfigValidation.java --- @@ -0,0 +1,382 @@ +/** --- End diff -- This file should

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821508 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/HdfsBlobStoreImpl.java --- @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821679 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java --- @@ -0,0 +1,278 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821665 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java --- @@ -0,0 +1,278 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43818090 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -954,6 +954,128 @@ public static final String SUPERVISOR_SLOTS_PORTS

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821851 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java --- @@ -0,0 +1,278 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821366 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java --- @@ -0,0 +1,382 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821343 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java --- @@ -0,0 +1,264 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821323 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java --- @@ -0,0 +1,264 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43821424 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/ClientBlobStore.java --- @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-1158] -Storm metrics to profile various...

2015-11-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/850#issuecomment-153950932 On nimbus, we need two additional counters for following Nimbus thrift ops `setWorkerProfiler` and `getComponentPendingProfileActions` --- If your project

[GitHub] storm pull request: [STORM-1157] Adding dynamic profiling for work...

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/842#issuecomment-153492437 @zhuoliu I moved docs under documentation location. Also, added pointers from main page. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: [STORM-1157] Adding dynamic profiling for work...

2015-11-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/842#issuecomment-153793312 @revans2 Fixed REST API documentation for consistency. Moved it to right location and added necessary link for Documentation.md --- If your project is set up

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43817942 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -954,6 +954,128 @@ public static final String SUPERVISOR_SLOTS_PORTS

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r43817867 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -954,6 +954,128 @@ public static final String SUPERVISOR_SLOTS_PORTS

[GitHub] storm pull request: [STORM-1157] Adding dynamic profiling for work...

2015-11-03 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/842#issuecomment-153595069 @zhuoliu I have updated the REST API documentation for all new endpoints. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: [STORM-1163] use rmr rather than rmpath for re...

2015-11-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/857#issuecomment-153824669 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1168] removes noisy log message & a TOD...

2015-11-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/858#issuecomment-153824526 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-162: Load Aware Shuffle Grouping

2015-11-06 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/847#issuecomment-154466432 LGTM. +1. This is helpful in managing load across multiple instances of component. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: [STORM-1158] -Storm metrics to profile various...

2015-11-06 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/850#issuecomment-154468111 LGTM. +1. Good bunch.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

  1   2   3   4   >