Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2916
@HeartSaVioR its mainly the tick tuple interval in HiveOptions that does
not apply to trident. For now may be we can log some warnings if that is set
for trident. Refactoring the code can
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2916
STORM-3292: flush writers in HiveState when the trident batch commits
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2909
STORM-3123 - add support for Kafka security config in storm-kafka-monitor
1.x version of https://github.com/apache/storm/pull/2906
You can merge this pull request into a Git repository
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2906#discussion_r233963942
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java
---
@@ -27,12 +27,15
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2906
@HeartSaVioR thanks for reviewing. Addressed comments.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2906
Have tested the changes with Kafka broker running in 2-way SSL and unsecure
modes and able to see the lags. The change on the kafka spout side is to return
the KafkaConfig properties
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2906
@VipinRathor
I pulled in the relevant changes from
https://github.com/apache/storm/pull/2760 and created this so that we can take
it forward. I need to do some tests and will update once
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2906
STORM-3123 - add support for Kafka security config in storm-kafka-monitor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2871
@revans2 , updated the log message, please check if it makes sense.
@kishorvpatil I am not sure if we want to swallow IOException, since it may
be due to some serious problem which we
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224559083
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2773
@HeartSaVioR created https://github.com/apache/storm/pull/2871 and linked
to a JIRA.
Maybe good to get this in 2.0 release.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2871#discussion_r224541248
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2871
Cherry picked commits from https://github.com/apache/storm/pull/2773 and
linked with a JIRA.
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2871
[STORM-3252] Bug fix for blobstore sync
1.Bug fix for blob sync frequency with time unit error.
2.Bug fix for blob sync delete file, add catch NoSuchFileException.
3.Bug fix for blob
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2829
@revans2 thanks for merging. Raised
https://github.com/apache/storm/pull/2835 for 1.x-branch.
>If you want to send more it can be more efficient, but you risk going o
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2835
STORM-3222: Fix KafkaSpout internals to use LinkedList instead of ArrayList
KafkaSpout internally maintains a waitingToEmit list per topic partition
and keeps removing the first item to emit
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2829
>what's the motivation to change this to LinkedList?
Its mentioned in the description. Heres the relevant code for some more
details -
https://github.com/apache/storm/blob/mas
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2829
Also I am not sure why the nextTuple only emits a single tuple wheres
ideally it should emit whatever it can emit in a single nextTuple call which is
more efficient. However the logic appears
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2829
STORM-3222: Fix KafkaSpout internals to use LinkedList instead of ArrayList
KafkaSpout internally maintains a waitingToEmit list per topic partition
and keeps removing the first item to emit
Github user arunmahadevan closed the pull request at:
https://github.com/apache/storm/pull/2498
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2773
Seems to fix a few race conditions, may be we can take this forward.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2773#discussion_r216796216
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2811
cc @HeartSaVioR
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2811
STORM-3184: Replace the usage of redact-value with ConfigUtils.maskPasswords
The topology submission can fail since redact-value expects a clojure map.
We don't need redact-value, it can
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2801#discussion_r209442754
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -52,6 +79,16 @@ public static ConfigUtils setInstance(ConfigUtils u
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2801#discussion_r209432875
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -52,6 +79,16 @@ public static ConfigUtils setInstance(ConfigUtils u
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
@HeartSaVioR heres the master port -
https://github.com/apache/storm/pull/2801
I guess sooner we release 2.0 and stick to master branch for even minor
feature development the better.
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2801
STORM-3184: Mask the plaintext passwords from the logs
Introduce a `Password` config annotation and use it to mark configs that are
sensitive and mask the values while logging
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
@HeartSaVioR , i had a quick look and its not straightforward to port this
patch to master. The Configs are now split into Config and DaemonConfig and
quite a lot of refactoring has happened
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
ping @HeartSaVioR
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2798
STORM-3184: Mask the plaintext passwords from the logs
Introduce a `Password` config annotation and use it to mark configs that are
sensitive and mask the values while logging.
You can
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2777
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2776
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2737
+1, LGTM
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2721
@revans2 , i have refactored the code so that we check for "user.name" in
the normal container and the result of `getWorkerUser` in the
RunAsUserContainer.
The `get
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2691
+1, Looks good.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2721
Also note that supervisor might be killing the workers in response to an
assignment change triggered by nimbus (may be due to user triggered kill or
rebalance) and the supervisor has no idea
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2721
Unless `supervisor.run.worker.as.user` is set, the worker process runs as
"storm" user. I guess the supervisor should always check "if all processes are
dead" by just l
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2721
@revans2 , @HeartSaVioR, can you take a look?
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2721
STORM-3110: Skip the user while checking isProcessAlive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-3110-1
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2712
Looks good.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2691
Actually I was wrong. storm-hdfs, storm-hbase, storm-hive seem to depend on
storm-autocreds. I guess we could pull out the required classes into some
common package as part of the follow up
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2691
Sure we can revisit this in a follow up JIRA.
We may not have to split the autocreds since none of the other components
depends on it. The hbase-server dependency if included is just
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2692
+1
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2691#discussion_r190424484
--- Diff: pom.xml ---
@@ -294,7 +294,7 @@
0.14.0
2.6.1
${hadoop.version}
-1.1.12
+1.4.4
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2687
+1 LGTM.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2639
@ptgoetz , can you take a look again?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2639
@ptgoetz , thanks for the suggestion.
Yes, it was clear why the distributed flag was needed when it was not used
anywhere else in the code. I was hoping that the user will set
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2639
@HeartSaVioR , I made some changes so that the order of the methods does
not matter and the final validation happens in "open". I also ran the example
topology and things look fine.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2672
+1 LGTM
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2671
+1 LGTM.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r187500706
--- Diff: external/storm-jms/pom.xml ---
@@ -94,7 +94,7 @@
maven-checkstyle-plugin
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2639
@HeartSaVioR , please check it again.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r187496374
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -403,50 +274,31 @@ public void ack(Object msgId
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r187496258
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -262,42 +189,26 @@ public void onMessage(Message msg
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r187496121
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -18,164 +18,124 @@
package
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r187496062
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -18,164 +18,124 @@
package
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r187495978
--- Diff: external/storm-jms/pom.xml ---
@@ -94,7 +94,7 @@
maven-checkstyle-plugin
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2639
This started out as a fix to handle the exceptions in "ack" when toCommit
was empty. However during the review process and testing, figured out many more
issues with the current appr
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2664
I think if we can shade all the storm-druid dependencies we could probably
leave it there.
At-least a few of the other storm connectors have not been updated in a
while but we still keep
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2664
Lets wait for a response. I think we can add some notes saying that
storm-druid is deprecated and shade its dependencies than completely removing
it since there are some users using
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2664
@revans2 thanks for understanding the concerns and agree that we should do
something about the long term support for tranquility. We can probably poke
them like @srdo suggested to get out
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2665
We should add docs and an example usage in the storm.yaml.example (which
has graphite and console). @dbist will be great if you address this for
JMXStormReporter as a part of this PR.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2665
@ptgoetz , any reason to use a different constant while this
[config](https://github.com/apache/storm/blob/1.x-branch/storm-core/src/jvm/org/apache/storm/Config.java#L179)
exists
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2664
@revans2 , I don't think we should completely drop the plugin since there
are users using it. There were a few options proposed
https://github.com/apache/storm/pull/2498#issuecomment-355423380
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2665#discussion_r186564318
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/JmxStormReporter.java ---
@@ -67,7 +68,7 @@ public void prepare(MetricRegistry
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2665#discussion_r186563440
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/JmxStormReporter.java ---
@@ -67,7 +68,7 @@ public void prepare(MetricRegistry
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r183539214
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -339,26 +339,26 @@ public void nextTuple
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2639#discussion_r183531789
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -339,26 +339,26 @@ public void nextTuple
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2643
+1
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2639
STORM-3035: fix the issue in JmsSpout.ack when toCommit is empty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2592
@HeartSaVioR , thanks for reviewing. Raised
https://github.com/apache/storm/pull/2610 for master.
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2610
STORM-2993: Storm HDFS bolt throws ClosedChannelException when Time
rotation policy is used
The TimedRotation should synchronize so that the bolt does not attempt to
write to a stale writer
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2592
STORM-2993: Storm HDFS bolt throws ClosedChannelException when Timed
rotation policy is used
The TimedRotation should synchronize so that the bolt does not attempt to
write to a stale writer
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2584
BUG-97743: Explicitly add jackson-annotations dependency in pom dependency
management
This is taken care of in master via jackson-bom dependency.
You can merge this pull request into a Git
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2570
STORM-2968: Exclude avro and commons-beanutils dependency from
storm-autocreds
1.x version of https://github.com/apache/storm/pull/2569
You can merge this pull request into a Git repository
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2569
STORM-2968: Exclude avro and commons-beanutils dependency from
storm-autocreds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2568
STORM-2967: Upgrade jackson to latest version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-2967-1.x
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2567
STORM-2967: Upgrade jackson to latest version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-2967
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2556
@ptgoetz the changes looks good.
1. Can you share the results of testing these changes with HBase 2.0
2. Are these changes compatible with HBase 1.x ? Can we try running
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2555
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2547
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2532
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2533
+1
Apparently the topology needs to use tick tuple to see the issue. Ran
RollingTopWords which uses tick-tuples and can clearly observe the difference.
**Before patch
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2533
Ran the FastWordCount with and without this patch, the number dont look
much different. FastWordcount is expected not to see any difference ? Maybe we
can wait for Alexandre's results
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2530
This is so that users could include the "external/storm-autocreds"
directory into their class path and have the delegation token mechanism for the
storm hdfs, hbase and hive conne
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2530
STORM-2907: Exclude curator dependencies from storm-core in storm-autocreds
pom
storm-autocreds brings in the curator 4.0 jars via transitive dependency of
storm-core. Even though storm-core
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2203
+1 again.
@HeartSaVioR , based on the TVL numbers I interpret that the performance
numbers (throughput and latency) are comparable to 1.x branch. In that case
can we merge this patch
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2519
+1
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2519#discussion_r162705370
--- Diff:
external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractAutoCreds.java
---
@@ -215,9 +215,17 @@ private void addTokensToUGI
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2519#discussion_r162679780
--- Diff:
external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractAutoCreds.java
---
@@ -216,8 +216,7 @@ private void addTokensToUGI
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2519
+1, Thanks for the patch. Can you also associate it with a JIRA and raise a
patch for master branch as well?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz can you squash the commits and also add some user documentation
for this?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz @HeartSaVioR , given that @revans2 was ok with the patch and the
performance concerns have been addressed, I suggest we merge this in and start
the RC process for Storm 1.2 release
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2515
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2516
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2499
@HeartSaVioR , are we ok to merge this in 1.x while we wait for the right
fix for #2498 ?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
I think "option 2" is good for Storm 2.0 and it may be ok have the users
rebuild their topologies that relies on storm-druid and use the relocated
package names. With "option
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
@revans2 , the latest version of tranquility-core available is 0.8.2 which
has this curator 2.6.0 transitive dependency.
I think the storm-druid unit tests would use the 2.6.0 version
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
@HeartSaVioR , any reason why we dont relocate in 2.0.0 vs 1.x ? If not
users would hit issues with conflicting versions (like curator).
---
1 - 100 of 787 matches
Mail list logo
