[GitHub] storm issue #1940: STORM-2361 Kafka spout - after leader change, it stops co...

2017-03-09 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1940 Ok, changed the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] storm issue #1940: STORM-2361 Kafka spout - after leader change, it stops co...

2017-03-09 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1940 Squashed the commits. About moving to STORM-2296 - I've put the links/relations to STORM-2296. But as the issue itself is already in "resolved" state - not sure how the patch coul

[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

2017-03-09 Thread ernisv
Github user ernisv commented on a diff in the pull request: https://github.com/apache/storm/pull/1940#discussion_r105104946 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java --- @@ -172,6 +187,12 @@ public void fail(Object msgId

[GitHub] storm issue #1940: STORM-2361 Kafka spout - after leader change, it stops co...

2017-03-06 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1940 Sure - braces added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

2017-02-14 Thread ernisv
GitHub user ernisv opened a pull request: https://github.com/apache/storm/pull/1940 STORM-2361 Kafka spout - after leader change, it stops committing offsets to ZK Try to route acks/fails to recreated partition managers if manager is not found by exact (broker, partition, topic

[GitHub] storm issue #1873: STORM-2296 Kafka spout - no duplicates on leader changes

2017-02-09 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1873 That's fine - i'll close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request #1873: STORM-2296 Kafka spout - no duplicates on leader c...

2017-02-09 Thread ernisv
Github user ernisv closed the pull request at: https://github.com/apache/storm/pull/1873 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1888: STORM-2296 Kafka spout no dup on leader changes, 1.x-bran...

2017-02-03 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1888 Ok, I've squashed all the changes to single commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1888: STORM-2296 Kafka spout no dup on leader changes, 1...

2017-02-03 Thread ernisv
Github user ernisv commented on a diff in the pull request: https://github.com/apache/storm/pull/1888#discussion_r99295805 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java --- @@ -114,6 +113,33 @@ public void testPartitionsChange() throws

[GitHub] storm pull request #1888: STORM-2296 Kafka spout no dup on leader changes, 1...

2017-02-03 Thread ernisv
Github user ernisv commented on a diff in the pull request: https://github.com/apache/storm/pull/1888#discussion_r99294074 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java --- @@ -114,6 +113,33 @@ public void testPartitionsChange() throws

[GitHub] storm pull request #1888: STORM-2296 Kafka spout no dup on leader changes, 1...

2017-02-03 Thread ernisv
Github user ernisv commented on a diff in the pull request: https://github.com/apache/storm/pull/1888#discussion_r99294012 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java --- @@ -114,6 +113,33 @@ public void testPartitionsChange() throws

[GitHub] storm issue #1873: STORM-2296 Kafka spout - no duplicates on leader changes

2017-01-19 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1873 Created another pull request for 1.x-branch: https://github.com/apache/storm/pull/1888 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request #1888: STORM-2296 Kafka spout no dup on leader changes 1 ...

2017-01-19 Thread ernisv
GitHub user ernisv opened a pull request: https://github.com/apache/storm/pull/1888 STORM-2296 Kafka spout no dup on leader changes 1 x Current behavior of Kafka spout emits duplicate tuples whenever Kafka topic leader's change. In case of exception caused by leader changes

[GitHub] storm issue #1873: Kafka spout - no duplicates on leader changes

2017-01-16 Thread ernisv
Github user ernisv commented on the issue: https://github.com/apache/storm/pull/1873 Created JIRA issue: https://issues.apache.org/jira/browse/STORM-2296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #1873: Kafka spout - no duplicates on leader changes

2017-01-12 Thread ernisv
GitHub user ernisv opened a pull request: https://github.com/apache/storm/pull/1873 Kafka spout - no duplicates on leader changes Current behavior of Kafka spout emits duplicate tuples whenever Kafka topic leader's change. In case of exception caused by leader changes