[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-11 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 Thanks erikdw! sorry i was out of office in the last couple of days. I just created a jira account and will create a jira ticket asap and assign to hmcl. --- If your project is set up

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-06 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @erikdw @hmcl , sorry for the late reply. include only part of my fixes is okie for me, we hope finally the community version has the proper fixes so we can use the community version. I don't

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-03 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl and all, we have communicated via email for a while and going forward let's talk in this thread so everyone is in same page. Base on the spout from the community(written by you), we have

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-08-17 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl and all, the new spout is fit for the at least once semantics and works fine for us, thanks a lot! Very recently one of our key customers asked to use a at most once implementation. Do we

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-06-17 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl, just fyi, we found one new issue: when rebalance happened, in method onPartitionsAssigned->initialize(Collection partitions) we can see below two lines: **final OffsetAndMetad

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-06-02 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl, today we found one NullpointerException and i applied a fix as below: In method doSeekRetriableTopicPartitions, if one partition was never committed before one message is failed

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-28 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-222308004 @hmcl, 1, work load is not distributed well is not because of the spout, that is a kafka cluster setup issue and now is resolved 2, for the other two, I dig

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-26 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-221922582 @hmcl, currently if user give firstPollOffsetStrategy=UNCOMMITTED_LATEST or LATEST, the spout will not work, because if a kafka consumer re-balance happened

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-24 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-221465746 @hmcl , sorry for the late reply, i was on leave and just now i send the updated spout to you, pls help review. Below is the major changes: 1. In poll method

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-23 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-221153889 @hmcl, could you share your email address? I will send our latest spout so you can have a quick review - this version is working in our testing env for about a week

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-22 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-220878934 @hmcl sorry for the late reply. we have made some quick and dirty fix for above issues, I will share the new spout to you via email so you can do a quick comparison

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-11 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-218453241 HI Hcml, Just fyi - In method doSeekRetriableTopicPartitions, we find below code: **kafkaConsumer.seekToEnd(rtp);// Seek to last committed offset

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-09 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-217905885 thanks Hmcl. Just found below log constantly show up, seems it constantly try to commit one offset which is actually committed to kafka already – it might

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-08 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-217781379 Just think another scenario – for example we polled 10k message and emitted – say from 10001 to 2, so the numUncommittedOffsets is 1, if the 10500 msg

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-08 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-217776015 Hi Hmcl, During our testing we found sometime the poll method was not called for long time, I suspect it is caused by below condition: private

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-04-22 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-213501159 Thanks hmcl for the documentation. For this time, please kindly help me to apply the suggested fix, I will create pull request myself going forward. --- If your

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-04-21 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-213211034 Hi, i am not sure if I should post a small issue here or anyone can tell me what is the formal process to do so? thanks! During the testing we found a small bug

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-02-29 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-190494188 Hi **@hmcl**, in some project we are tracking the DB activities, we may need the message to be emitted in same sequence as they were polled from Kafka - i.e. polled 5

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-02-21 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-186820101 Hi **@hmcl **, is there any update on the patch please? thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-02-17 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-185525958 **@hmcl ** thanks a lot i understand the complexity. Appreciate your help and it would be great to see your patch by EOD today your time. --- If your project is set

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-02-17 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-185258481 Hi **@hmcl **, could you please share the patch please? thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-02-17 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-185257444 Hi @**hmcl **, could you please share the patch please? thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-02-15 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-184563880 Hi **@hmcl** ,may I have the patch please? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-02-10 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-182423997 Hi @hmcl, that's good news, thanks for that! I will add your patch this weekend or early next Monday to our QA environment- next week we will run majority of the QA

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-01-31 Thread jianbzhou
Github user jianbzhou commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-177696306 Hi @hmcl, this is Wayne from connieyang's team, not sure could you please provide a patch for us to kick off the testing? We are doing the QA testing this week