[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii closed the pull request at: https://github.com/apache/storm/pull/1470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan yes, check #1811 please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #1811: STORM-1886 Extend KeyValueState iface with delete

GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1811 STORM-1886 Extend KeyValueState iface with delete The same as #1470, just against the [1.x-branch](https://github.com/apache/storm/tree/1.x-branch) This pull request incorporates #1606

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan actually my patch depends on #2020, which isn't yet in 1.x-branch. how should we proceed? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request #1809: STORM-1886 Extend KeyValueState iface with delete

Github user kosii closed the pull request at: https://github.com/apache/storm/pull/1809 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1809: STORM-1886 Extend KeyValueState iface with delete

GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1809 STORM-1886 Extend KeyValueState iface with delete The same as #1470, just against the 1.x-branch You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 Yes, I'll look into that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan I'm very sorry for disappearing for such a long time. I addressed all the comments, I also fixed the race condition in my last commit --- If your project is set up for it, you can

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @HeartSaVioR I addressed most of the comments in my local repo, but not pushed yet. If I have some time this week (probably Friday) I'll clean it up, and commit. Sorry for the delay --- If your

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r69322053 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -161,7 +176,11 @@ public void prepareCommit(long txid

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r69321607 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -60,22 +64,23 @@ public RedisKeyValueState(String

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r69321335 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -60,22 +64,23 @@ public RedisKeyValueState(String

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 A short list of modifications - I went for the `Optional` class. Using your idea largely simplified the code. - delete now returns the current value - I didn't use a different set

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r68263894 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -203,12 +237,14 @@ public void commit

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r68263881 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -184,15 +216,17 @@ public void commit(long txid

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r68261133 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -77,7 +81,8 @@ public RedisKeyValueState(String

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r68260812 --- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java --- @@ -45,4 +45,11 @@ * @return the value or defaultValue if no mapping

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1470#discussion_r68260007 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java --- @@ -163,15 +190,20 @@ public void prepareCommit(long

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 Thanks @arunmahadevan for the thorough review, I'm gonna address each comments asap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm issue #1453: STORM-1873 Implement alternative behaviour for late tuple...

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1453 @arunmahadevan @satishd nit is fixed and commits are squashed. thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request #1470: STORM-1886 Extend KeyValueState iface with delete

GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1470 STORM-1886 Extend KeyValueState iface with delete The patch also provides implementation for delete in RedisKeyValueState and InMemoryKeyValueState. You can merge this pull request into a Git

[GitHub] storm pull request #1464: STORM-1884: Prioritize pendingPrepare over pending...

GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1464 STORM-1884: Prioritize pendingPrepare over pendingCommit You can merge this pull request into a Git repository by running: $ git pull https://github.com/s4mDev/storm fix_storm_1884

[GitHub] storm pull request #1453: STORM-1873 Implement alternative behaviour for lat...

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1453#discussion_r65866008 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -188,6 +189,10 @@ private void validate(Map stormConf, Count

[GitHub] storm issue #939: [STORM-1175] State store for windowing operations

Github user kosii commented on the issue: https://github.com/apache/storm/pull/939 @arunmahadevan yes, I'm on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request #:

Github user kosii commented on the pull request: https://github.com/apache/storm/commit/4623d8f87f044a9a8737a55bd32f955485900ce1#commitcomment-17749543 In external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java: In external/storm-redis/src/main

[GitHub] storm pull request #:

Github user kosii commented on the pull request: https://github.com/apache/storm/commit/4623d8f87f044a9a8737a55bd32f955485900ce1#commitcomment-17749399 In external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java: In external/storm-redis/src/main

[GitHub] storm pull request #1453: STORM-1873 Implement alternative behaviour for lat...

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1453#discussion_r65580954 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -284,6 +298,10 @@ public void cleanup() { @Override

[GitHub] storm issue #1453: STORM-1873 Implement alternative behaviour for late tuple...

Github user kosii commented on the issue: https://github.com/apache/storm/pull/1453 I updated the docs, and I'm going to work on the unit tests while the patch is being reviewed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request #1453: STORM-1873 Implement alternative behaviour for lat...

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1453#discussion_r65557613 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -1872,6 +1872,13 @@ @isString public static final String

[GitHub] storm pull request #1453: STORM-1873 Implement alternative behaviour for lat...

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1453#discussion_r65557653 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -268,8 +277,12 @@ public void execute(Tuple input

[GitHub] storm pull request #1453: STORM-1873 Implement alternative behaviour for lat...

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1453#discussion_r65527974 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -1872,6 +1872,13 @@ @isString public static final String

[GitHub] storm pull request: STORM-1873 Implement alternative behaviour for late tupl...

GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1453 STORM-1873 Implement alternative behaviour for late tuples You can merge this pull request into a Git repository by running: $ git pull https://github.com/kosii/storm late-tuple-poc-2

[GitHub] storm pull request: STORM-1859: Ack late tuples in windowed mode

Github user kosii commented on the pull request: https://github.com/apache/storm/pull/1437#issuecomment-220916990 @arunmahadevan cool, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: Ack late tuples in windowed mode

GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1437 Ack late tuples in windowed mode The current implementation simply ignores late tuples without acking them, which causes timeouts and replays after TOPOLOGY_MESSAGE_TIMEOUT_SECS. A tuple which