[GitHub] storm pull request #1611: storm-2022: fix test case

2016-08-05 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1611 storm-2022: fix test case Sorry, my bad. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm storm-2022 Alternatively you can

[GitHub] storm pull request #1582: A better way to get default value

2016-07-21 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1582 A better way to get default value A better way to get default value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-11 Thread lujinhong
Github user lujinhong commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r70235783 --- Diff: storm-core/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java --- @@ -0,0 +1,155 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-04 Thread lujinhong
Github user lujinhong commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r69502037 --- Diff: storm-core/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java --- @@ -0,0 +1,243 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1522: [STORM-1594] org.apache.storm.tuple.Fields can thr...

2016-06-29 Thread lujinhong
Github user lujinhong commented on a diff in the pull request: https://github.com/apache/storm/pull/1522#discussion_r68908757 --- Diff: storm-core/src/jvm/org/apache/storm/tuple/Fields.java --- @@ -50,8 +50,12 @@ public Fields(List fields) { public List select

[GitHub] storm pull request #1522: [STORM-1594] org.apache.storm.tuple.Fields can thr...

2016-06-26 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1522 [STORM-1594] org.apache.storm.tuple.Fields can throw NPE if given invalid field in selector fix STORM-1594. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1388#issuecomment-216717573 sorry, please check https://github.com/apache/storm/pull/1395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
Github user lujinhong closed the pull request at: https://github.com/apache/storm/pull/1388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1395 storm-1726: use Put#addColumn to replace the deprecated Put#add You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm 1.x-branch

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1388 storm-1726: use Put#addColumn to replace the deprecated Put#add You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm storm-hbase

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-04-22 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-213647983 https://issues.apache.org/jira/browse/STORM-1726?filter=12335179 --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Created] (STORM-1726) use Put#addColumn to replace the deprecated Put#add

2016-04-22 Thread lujinhong (JIRA)
lujinhong created STORM-1726: Summary: use Put#addColumn to replace the deprecated Put#add Key: STORM-1726 URL: https://issues.apache.org/jira/browse/STORM-1726 Project: Apache Storm Issue Type

[GitHub] storm pull request: use Put#addColumn to replace the deprecated Pu...

2016-04-21 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1353 use Put#addColumn to replace the deprecated Put#add Besides that, any plan to use Table to replace HTable, and use BufferMutation to cache ? You can merge this pull request into a Git repository

[GitHub] storm pull request: modify delegateIndex to protected

2016-03-25 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1259 modify delegateIndex to protected The delegateIndex field in ValuePointer is only used in TridentTupleView, which is in the same package. You can merge this pull request into a Git repository

[GitHub] storm pull request: add field argument to newDRPCStream

2016-03-25 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1258 add field argument to newDRPCStream Add argument to newDRPCStream, and default field is "args" which is the same with before. You can merge this pull request into a Git repository

[GitHub] storm pull request: Hbasemapstate

2016-03-19 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1225 Hbasemapstate Add HBaseMapState demo You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm hbasemapstate Alternatively you can

[GitHub] storm pull request: add private constructor to KafkaUtils

2016-03-04 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1186 add private constructor to KafkaUtils Since all of the methods and fields are static, I think it is a good idea to add a private constructor to KafkaUtils to avoid been constructed. You can

[GitHub] storm pull request: add some log in DynamicBrokersReader#getLeader...

2016-02-29 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1165 add some log in DynamicBrokersReader#getLeaderFor() It will useful for debug in non-English enviroment. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm pull request: [storm-1456]: Cannot check for ack or fail in ...

2016-02-29 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1164 [storm-1456]: Cannot check for ack or fail in FixedTupleSpout You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm storm-1456

[GitHub] storm pull request: remove duplicate semecolon

2016-02-26 Thread lujinhong
Github user lujinhong closed the pull request at: https://github.com/apache/storm/pull/1134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: remove duplicate semecolon

2016-02-26 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1152#issuecomment-189182904 because the repo of #1134 has been deleted, and @zhuoliu said " Can you please create a named branch in your repository and then do the pull request? Othe

[GitHub] storm pull request: remove duplicate semecolon

2016-02-25 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1134#issuecomment-189072414 A new PR is here #1152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: remove duplicate semecolon

2016-02-25 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1152 remove duplicate semecolon You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm duplicate_semecolon Alternatively you can review

[GitHub] storm pull request: [STORM-1065] kafka-partition can not find lead...

2016-02-23 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1146 [STORM-1065] kafka-partition can not find leader in zookeeper fix [STORM-1065] kafka-partition can not find leader in zookeeper You can merge this pull request into a Git repository by running

[GitHub] storm pull request: [STORM-1065] kafka-partition can not find lead...

2016-02-23 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1140#issuecomment-188110642 refresh my fork, close this PR, I will commit another one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: [STORM-1065] kafka-partition can not find lead...

2016-02-23 Thread lujinhong
Github user lujinhong closed the pull request at: https://github.com/apache/storm/pull/1140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: [STORM-1065] kafka-partition can not find lead...

2016-02-23 Thread lujinhong
Github user lujinhong closed the pull request at: https://github.com/apache/storm/pull/1132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: [STORM-1065] kafka-partition can not find lead...

2016-02-23 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1140 [STORM-1065] kafka-partition can not find leader in zookeeper #1132 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm master

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-02-22 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-187582981 +1 on trident spout --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-22 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1132#issuecomment-187501380 1. when refreshFreqSecs expired, it will refresh. 2. for the second, I think it is about the task-partition mapping mechanism,is it in the clojure code of Task

[GitHub] storm pull request: remove duplicate semecolon

2016-02-22 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1134 remove duplicate semecolon just a little fix: remove duplicate semecolon. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm dev

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-21 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1132#issuecomment-186987218 In KafkaUtil.java, NOT_LEADER_FOR_PARTITION happend, catching the NOT_LEADER_FOR_PARTITION execption will be a good idea. This exception should be catch

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-02-21 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-186986537 In KafkaUtil.java, NOT_LEADER_FOR_PARTITION happend, may catch the NOT_LEADER_FOR_PARTITION execption will be a good idea. This exception should be catch

[GitHub] storm pull request: storm-kafka : kafka-partition can not find lea...

2016-02-21 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1132 storm-kafka : kafka-partition can not find leader in zookeeper #1132 STORM-1065. storm-kafka : kafka-partition can not find leader in zookeeper You can merge this pull request into a Git

[GitHub] storm pull request: STORM-917 : Ability to emit from the spout to ...

2016-02-20 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/601#issuecomment-186567237 what about trident? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: MINOR: Use /usr/bin/env to find bash

2015-11-19 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/892#issuecomment-158262273 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled