GitHub user omerhadari opened a pull request:
https://github.com/apache/storm/pull/2236
STORM-2652: fix error in open method of JmsSpout
I changed the casting to `Number` instead of `Integer`
since it is actually a `Long`, and it caused a `ClassCastException`
to be thrown
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
I have no permissions to do that. I reopened the issue so that someone who
can assigns it to me.
Will work on the 1.x PR ASAP. Thanks for the merge.
---
If your project is set up for it, you
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
No problem, I'll open a separate PR tomorrow evening.
Do let me know if this one needs any further work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
I tried looking into the failed integration test, and I believe it has
nothing to do with the classes I touched (especially since it looks to have
passed a few commits earlier, all of which
Github user omerhadari commented on a diff in the pull request:
https://github.com/apache/storm/pull/2234#discussion_r128855869
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -72,19 +72,18 @@
private static final Logger LOG
Github user omerhadari commented on a diff in the pull request:
https://github.com/apache/storm/pull/2234#discussion_r128853255
--- Diff:
external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
@@ -30,65 +35,110 @@
import javax.jms.MessageListener
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
I see, Fixed that as well.
See if you think someone needs to take a look and verify that my style
fixes are the correct ones :)
---
If your project is set up for it, you can reply
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
I fixed all style issues reported in `checkstyle-violations.xml` regarding
the files I touched, and it still failed. I check out master and ran `mvn
checkout:check`, it failed there. Too
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
Well I have fixed all violations for the files I touched, but it still over
many style violations in other files. I'd be more than happy to fix them in a
separate PR, but for the scope
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
This still fails due to stylecheck because of numerous error regarding
lines I have not touched.
I do not mind fixing them, but I don't know if it is within the scope of
this PR. What do you
Github user omerhadari commented on the issue:
https://github.com/apache/storm/pull/2234
Done, and done
https://issues.apache.org/jira/browse/STORM-2652
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user omerhadari opened a pull request:
https://github.com/apache/storm/pull/2234
Bugfix/fix configuration cast exception
I open this PR since I was delighted to see that there is an existing JMS
spout implementation, but encountered a bug when trying to use it. The bug
13 matches
Mail list logo
