GitHub user redsanket opened a pull request:
https://github.com/apache/storm/pull/1852
[STORM-2271] ClosedByInterruptException should be handled in few cases and
removing a confusing debug statement
You can merge this pull request into a Git repository by running:
$ git pull
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1837#discussion_r94053490
--- Diff:
storm-core/src/jvm/org/apache/storm/security/auth/SaslTransportPlugin.java ---
@@ -64,8 +64,14 @@ public void prepare(ThriftConnectionType type
GitHub user redsanket opened a pull request:
https://github.com/apache/storm/pull/1837
[STORM-2254] Provide Socket time out for nimbus thrift client
For DRPC we have seen during our integration tests that the connection
needs to be up for more than 10 minutes so not adding any
Github user redsanket commented on the issue:
https://github.com/apache/storm/pull/1726
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user redsanket commented on the issue:
https://github.com/apache/storm/pull/1720
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user redsanket commented on the issue:
https://github.com/apache/storm/pull/1680
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/648
@harshach updated and squashed thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1398#discussion_r64245422
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -45,6 +47,7 @@
import
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1439#issuecomment-221018949
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1440#issuecomment-220812909
@abhishekagarwal87 There seems to be a KafkaBoltTest failure, can you take
a look at it
---
If your project is set up for it, you can reply to this email and have
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1397#issuecomment-218603864
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1290#issuecomment-218603288
@HeartSaVioR reverted the last commit, hopefully it is good to go
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1271#issuecomment-218602496
@HeartSaVioR, sorry about the last commit, reverted it, hope it is ready to
go, thanks
---
If your project is set up for it, you can reply to this email and have
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1370#issuecomment-215741544
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1313#issuecomment-207073888
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1315#issuecomment-206568170
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1314#issuecomment-206568089
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1311#issuecomment-206451308
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1312#issuecomment-206451182
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1310#issuecomment-206450960
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1271#issuecomment-204228944
@revans2 Added the config
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user redsanket opened a pull request:
https://github.com/apache/storm/pull/1290
[YSTORM-1661] Added acl validation config 1.x Branch PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/redsanket/storm STORM-1661-1.x
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1271#issuecomment-203516589
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1207#issuecomment-202979099
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user redsanket opened a pull request:
https://github.com/apache/storm/pull/1271
[STORM-1661] Introduce ACL Validation config for insecure mode
With PlainSaslTransport, in scenarios where insecure environments pick a
cluster user to launch the daemons and the topology
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1195#issuecomment-202581682
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1241#issuecomment-199343737
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1229#issuecomment-197915743
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1226#issuecomment-198013271
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56659070
--- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -0,0 +1,372 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56658785
--- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -0,0 +1,372 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1195#issuecomment-197508158
Most of the changes look good, just a question about jmx reporter
implementation
---
If your project is set up for it, you can reply to this email and have your
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56381761
--- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1227#issuecomment-198032722
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56383389
--- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56382441
--- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56383870
--- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56366424
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1353,8 +1353,8 @@
(str "Failed to submit topology. Topology req
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56381799
--- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/Pacemaker.java ---
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1195#issuecomment-198018090
@hustfxj I guess it is more like a plugin to get metrics. I presume the
code should be implemented. @knusbaum might be right to answer it.
---
If your project is set
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1195#discussion_r56387356
--- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj ---
@@ -1,242 +0,0 @@
-;; Licensed to the Apache Software Foundation (ASF) under
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1211#issuecomment-196424927
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1073#issuecomment-196423667
@harshach upmerged and squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1191#discussion_r55696301
--- Diff:
storm-core/test/jvm/org/apache/storm/security/auth/AuthUtilsTest.java ---
@@ -0,0 +1,240 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1194#issuecomment-194848650
Agree, that is a bigger change and I will have a follow up jira for it.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1194#discussion_r55561657
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -151,10 +159,43 @@
bootstrap = createClientBootstrap(factory
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1194#discussion_r55546601
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -151,10 +159,43 @@
bootstrap = createClientBootstrap(factory
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1194#issuecomment-194000825
@d2r Addressed your comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1194#discussion_r55441072
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -108,6 +110,13 @@
private final AtomicInteger messagesLost = new
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1194#discussion_r55441002
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -151,10 +164,35 @@
bootstrap = createClientBootstrap(factory
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1194#discussion_r55440955
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -151,10 +164,35 @@
bootstrap = createClientBootstrap(factory
GitHub user redsanket opened a pull request:
https://github.com/apache/storm/pull/1194
[STORM-1609] Netty Client is not best effort delivery on failed Connection
If Worker-A has connection to Worker-B that is unused ( and if Worker-B
restarted), we drop messages because Channel
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-192486048
upmerge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1176#issuecomment-191805167
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1054#issuecomment-188304984
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1100#issuecomment-187425147
Very minor comment, not significant LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1100#discussion_r53707969
--- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1119#issuecomment-187270623
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1119#issuecomment-186660058
upmerge please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1073#issuecomment-186426067
@revans2 @knusbaum @abhishekagarwal87 still +1 ? Hope it is languishing too
long out here.
---
If your project is set up for it, you can reply to this email and have
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1100#issuecomment-186359753
upmerge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1128#issuecomment-186359390
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1116#discussion_r53500680
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -146,8 +146,10 @@
(logviewer-link host (event-logs-filename topology-id port) secure
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1096#issuecomment-185945096
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1121#issuecomment-185935749
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1114#issuecomment-185934259
minor comments otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53386906
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53386858
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,98 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1119#issuecomment-185929123
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1113#issuecomment-185593696
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53209094
--- Diff: storm-core/test/jvm/org/apache/storm/utils/UtilsTest.java ---
@@ -0,0 +1,221 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53208394
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53208097
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53207784
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53200197
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user redsanket closed the pull request at:
https://github.com/apache/storm/pull/1106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1055#discussion_r52844340
--- Diff: storm-clojure/pom.xml ---
@@ -0,0 +1,83 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1055#issuecomment-183929785
@revans2 addressed comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1073#discussion_r52829338
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1446,6 +1448,22 @@ public static RuntimeException
wrapInRuntime(Exception e
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1102#issuecomment-183372754
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1055#issuecomment-183436838
@revans2 rebased..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1073#issuecomment-183461680
@abhishekagarwal87 @knusbaum please take a look at it, it must go into
Utils.java
---
If your project is set up for it, you can reply to this email and have your
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1073#issuecomment-183462361
Just a moment, will test it once more
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1104#discussion_r52792355
--- Diff: storm-core/src/jvm/org/apache/storm/command/CLI.java ---
@@ -0,0 +1,229 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
GitHub user redsanket opened a pull request:
https://github.com/apache/storm/pull/1106
[STORM-1547] Pacemaker read aggregations
1. Please note current request does not involve write with HA
2. Only reads and read aggregations are present in the current PR
You can merge
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1073#issuecomment-183524404
@revans squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1093#issuecomment-182045968
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1075#issuecomment-180412081
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1075#discussion_r51974741
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -140,6 +140,45 @@
public static final String STORM_META_SERIALIZATION_DELEGATE
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1079#issuecomment-180200298
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1065#issuecomment-180188256
upmerge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1079#discussion_r51976825
--- Diff: documentation/Setting-up-development-environment.md ---
@@ -29,13 +29,5 @@ Installing a Storm release locally is only for
interacting with remote
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1059#issuecomment-180189026
LGTM, minor clarification
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1073#discussion_r51890142
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1374,5 +1393,29 @@ public static RuntimeException
wrapInRuntime(Exception e
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1073#discussion_r51919544
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1374,5 +1393,29 @@ public static RuntimeException
wrapInRuntime(Exception e
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1073#discussion_r51920715
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1374,5 +1393,29 @@ public static RuntimeException
wrapInRuntime(Exception e
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/1073#issuecomment-180037148
@revans2 @abhishekagarwal87 fixed the issues I presume. Let me know if you
have any concerns
---
If your project is set up for it, you can reply to this email
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51785738
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51790816
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51786510
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
1 - 100 of 279 matches
Mail list logo
