Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1482
Hey guys, can you take a look now?
1. changed the scopes as discussed in #1556
2. Updated the readme with information regarding maven parameters as well
as kafka api compatibility
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1482
@abhishekagarwal87 Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1482
+1 besides the neat pick which would be to have the new spout property
names prefixed by `storm.kafka.client` property names for consistency.
---
If your project is set up for it, you can reply to
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1482
I am still +1 on merging this. As @ptgoetz stated lets document this in
README
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1482
@abhishekagarwal87 @HeartSaVioR @unsleepy22 currently we are hard-coding
the version here
https://github.com/apache/storm/blob/master/external/storm-kafka/pom.xml#L34 .
Without having this
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1482
The README needs to be updated for this change with instructions on how to
use different Kafka client and scala versions.
I'm okay with either leaving or removing the `provided` scope for
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1482
@harshach @hmcl - can you guys take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1482
I guess what we would want is
- We describe default version of storm-kafka and storm-kafka-client clearly
so that users can use it directly when version is matched to what users want.
-
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1482
Thanks @harshach and @unsleepy22 for comments. Even I would like to
understand more on how these options are to be used :)
@harshach @hmcl - can you add some details here?
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1482
Great @unsleepy22 you got the point.
@abhishekagarwal87 I guess you want to address also doc since you mark
component of issue to also 'documentation'. Could you address this?
---
If your
Github user unsleepy22 commented on the issue:
https://github.com/apache/storm/pull/1482
Should we change the README.md accordingly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1482
+1 Nice addressing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1482
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
13 matches
Mail list logo
