[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1702 @raviperi do you have JIRA filed here for this https://issues.apache.org/jira/browse/STORM/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1702 No, this seems fine. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1702 +1. @srdo do you have any further comments pending. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1702 I am not really familiar with EventHub all that much so I don't really feel all that confident in reviewing it. I mostly jumped on to answer a few generic questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user raviperi commented on the issue: https://github.com/apache/storm/pull/1702 @revans2 Please let me know if you have further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user raviperi commented on the issue: https://github.com/apache/storm/pull/1702 Created a new PR https://github.com/apache/storm/pull/1717 for the master branch. Created a new JIRA that reflects the need for the aboce work. STORM-2127 - Storm-eventhubs should use latest amqp and eventhubs-client versions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user raviperi commented on the issue: https://github.com/apache/storm/pull/1702 The latest PR addresses the above comments . Move dependencies to parent pom . Revert changes to versions to reflect naming convention. I will be sending a different PR to master branch, that includes the above changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1702 Is there a similar pull request to master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1702 Btw, IMO, upgrading the dependency is worth to file an issue. @raviperi Could you file it and copy description of PR to issue's description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1702 Hm, nevermind the new client, it requires Java 8. It's still an option for Storm 2.0 though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1702: Update Eventhub-Client jar dependency to 1.0.1
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1702 This seems fine once the storm versions are reverted, though you should get this on the master branch first. I'd like to mention before you spend too much time on trying to make the spout run reliably, that we've had some reliability problems with the com.microsoft.eventhubs.client:eventhubs-client since the underlying AMQP library isn't being maintained. There's a new eventhub client here based on Apache Proton which is likely to provide a better experience. https://github.com/Azure/azure-event-hubs/tree/master/java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
