Github user liurenjie1024 commented on the issue:
https://github.com/apache/storm/pull/1884
@HeartSaVioR Commits squashed, please help to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1884
Travis CI build failure is unrelated and fix is available (#1887)
@liurenjie1024
Could you please squash the commits into one? Ideally commit title would be
`STORM-2236 Add manual
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1884
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1884
@liurenjie1024 TopicPartitionComparator missing Apache License. Can you add
that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1884
+1. Thanks @liurenjie1024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user liurenjie1024 commented on the issue:
https://github.com/apache/storm/pull/1884
@harshach This is a commit for 1.x-branch without function interface, could
you please help to merge it?
---
If your project is set up for it, you can reply to this email and have your
reply
