Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
Thanks @revans2 +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng Fixed the issue. We were only checking if the SybSystem was
enabled, but not if it was mounted.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng Actually just found a bug working on a fix now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
Thanks @revans2 +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng I added in the extra documentation you wanted, and I spell
checked the whole thing.
I also updated the CGroupCpuGuarantee metric to let the parent handle the
exception.
---
If
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
thanks @revans2 for taking the time to refactor some of the code! I
reviewed it once more. If there is an example of how to user the metrics in
the docs I think that would be extremely helpful
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1934
@jerrypeng Please take another look. I refactored the code to reuse the
CgroupManager and such.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
@revans2 this is a really cool feature and thanks for adding it. My only
question is that I see you have implemented some parsers/getters for the cgroup
metrics. There is already a set of them
