[GitHub] storm issue #2300: STORM-2691: Make storm-kafka-client implement the Trident...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2300 @srdo Yeah I was aware that you talked offline but I couldn't get any indication that concern of the patch is resolved, since @hmcl talked about another issue at that time. Regarding breaking backward compatibility, if it is needed to fix "broken" thing, we would want to do that instead of leaving it as broken. Let's raise discussion thread and see there's objection about breaking it. ---
[GitHub] storm issue #2300: STORM-2691: Make storm-kafka-client implement the Trident...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2300 Thanks for the reviews. @HeartSaVioR Sorry, @hmcl and I talked offline a while ago. It's my impression that we're good. I'm not planning to port this to 1.x, since it requires breaking changes. I can't think of a way to fix this without replacing the Subscription interface. ---
[GitHub] storm issue #2300: STORM-2691: Make storm-kafka-client implement the Trident...
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2300 +1 ---
[GitHub] storm issue #2300: STORM-2691: Make storm-kafka-client implement the Trident...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2300 Rebased to fix conflicts. ---
[GitHub] storm issue #2300: STORM-2691: Make storm-kafka-client implement the Trident...
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2300 @srdo this change should go on https://github.com/apache/storm/pull/2174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
