[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2487 closing the PR as no longer needed for master branch. ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2487 @kishorvpatil If we are not going to merge this into master could you close it? ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2487 @HeartSaVioR, Please find patch for 1.x-branch - https://github.com/apache/storm/pull/2529 ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2487 @kishorvpatil Any updates? ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2487 Ok. I will create the PR for 1.x-branch. ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2487 @kishorvpatil could you put up a pull request to 1.x for this? ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2487 +1 for the change, but only applying to 1.x version line. (-1 for merging in master branch) We're changing backpressure model in [STORM-2306](https://issues.apache.org/jira/browse/STORM-2306) which got remove of usage of ZK for backpressure, and I think the PR is getting closer to the finish line (target to be included to Storm 2.0.0), hence I don't want to make things conflict. ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2487 Nevermind, timestamp is 0 when the backpressure flag is off. I wasn't paying enough attention :). ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2487 +1 LGTM. I'm a little confused by when the removed case would be hit though. As far as I can tell it's only called from daemon/worker/Worker.java, and it doesn't look to me like the timestamp parameter can be negative there? ---
[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2487 @srdo , Please review changes addressing the comments. ---
