[GitHub] storm issue #2560: STORM-2896: Add tool to help users migrate offsets from s...

2018-02-23 Thread srdo
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2560
  
@HeartSaVioR Thanks for reviewing. Addressed the comments. Yes, I migrated 
offsets from both a regular spout and a trident spout, both for a regular topic 
and a wildcard subscription. For the regular spout, I think it's good enough to 
show that the offsets a migrated to the specified consumer group, so I didn't 
bother setting up a storm-kafka-client spout. For Trident I set up a 
storm-kafka-client Trident topology and checked that the new topology picked up 
where the storm-kafka topology left off.


---


[GitHub] storm issue #2560: STORM-2896: Add tool to help users migrate offsets from s...

2018-02-19 Thread srdo
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2560
  
Thanks, will make a master branch version.


---


[GitHub] storm issue #2560: STORM-2896: Add tool to help users migrate offsets from s...

2018-02-18 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2560
  
I think it would be last call to migrate if this is shipped to master 
branch. So I think it would be good to have in 2.0.0. We may not want to have 
it in 3.0.0 version line.


---


[GitHub] storm issue #2560: STORM-2896: Add tool to help users migrate offsets from s...

2018-02-18 Thread srdo
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2560
  
Added tool to migrate Trident spouts.


---