Github user d2r commented on the issue:
https://github.com/apache/storm/pull/459
New changes are to remove warning suppression attributes and look good to
me. +1 again.
Thanks @krichter722 for the changes and for your patience. I have merged
this to master.
---
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/459
@krichter722 thanks for this!
---
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/459
+1
---
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
> we can hold off if you want to clean up these unnecessary annotations.
Done.
---
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/459
> I just realized that this PR makes a lot of @SuppressWarning("rawtypes")
unnecessary. What do you think about adding that as a second commit to this PR?
@krichter722 Sorry for the delay; yes we
Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/459
I just realized that this PR makes a lot of `@SuppressWarning("rawtypes")`
unnecessary. What do you think about adding that as a second commit to this PR?
---
