[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2015-03-19 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-83749375 @revans2 Thank you. I have merged in the changes. Sorry for delay. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2015-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-72688638 I rebased it so it would merge cleanly. @kishorvpatil if you could take a look again that would be great. --- If your project is set up for it, you can reply to this ema

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2015-01-27 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-71722168 @revans2 could you please upmerge the change again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2015-01-27 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-71722015 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2014-12-22 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-67892015 I just upmerged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2014-11-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-64690420 Thanks for the advice. I switched the style over to be compact for the tables. I also fixed an issue with they layout on fire fox where the table always filled more than t

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2014-11-26 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-64682472 `Tooltip` placing/formatting etc seems to have changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2014-11-26 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-64673038 For dataTables, I would recommend the use of `compact` class to reduce the amount of white-space, instead of `stripe` --- If your project is set up for it, you can r

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2014-11-25 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/328 [STORM-570] replace table sorter with data table. Also upraded several ... ...javascript libraries to latest versions to make integration simpler. I know this is kind of a lot. I upgraded to