Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/845
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-161798173
@ptgoetz Thanks for the review. I agree with the follow on items. Because
this is such a big change and @redsanket has been upmerging this regularly I
would like to
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-161736488
@redsanket First of all thank you for contributing this and making it
through the most epic code review we've had to date. :)
I'm +1 for merging this as is, but
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46338107
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -728,29 +848,92 @@
(.shutdown supervisor)
)
-(defn
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-161019859
@ptgoetz , @harshach , @Parth-Brahmbhatt
I have enough +1's at this point but would be nice if you could take a look
at it before it goes in
---
If your project
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46205703
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/ClientBlobStore.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46203383
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/ClientBlobStore.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-160761949
Things look good to me. I am +1 on this going in. I had one comment about
getting some documentation for the ClientBlobStore.java interface. But that
can go in later
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46154410
--- Diff: pom.xml ---
@@ -469,7 +475,11 @@
curator-client
${curator.version}
-
+
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-160727100
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-160730596
+1, thanks for your work and patience, @redsanket
@revans2, @kishorvpatil , @unsleepy22 , @ptgoetz, It looks as if your
comments have been addressed.
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-160755034
@d2r I have squashed the commits.
Thanks a lot to @revans2, @kishorvpatil , @unsleepy22 , @ptgoetz, @knusbaum
,@d2r for helping me get a thorough review and fix
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-160803909
@revan2 updated docs. Let me know if you think more information needs to go
in. Thanks
---
If your project is set up for it, you can reply to this email and have your
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46099843
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,296 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46100043
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/NimbusBlobStore.java
---
@@ -0,0 +1,408 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46094594
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46094374
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/NimbusBlobStore.java
---
@@ -0,0 +1,408 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46104071
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46101459
--- Diff: pom.xml ---
@@ -469,7 +475,11 @@
curator-client
${curator.version}
-
+
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46101477
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java
---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46100242
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/NimbusBlobStore.java
---
@@ -0,0 +1,419 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46024124
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,296 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46024323
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,296 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46026089
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/NimbusBlobStore.java
---
@@ -0,0 +1,408 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46026035
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/NimbusBlobStore.java
---
@@ -0,0 +1,408 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46018454
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java
---
@@ -0,0 +1,518 @@
+/**
+ * Licensed to the
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46018606
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -90,9 +86,14 @@
(update-storm! [this storm-id new-elems])
(remove-storm-base!
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46019849
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,444 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46020033
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46020162
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46020567
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46020634
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46017804
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java
---
@@ -0,0 +1,379 @@
+/**
+ * Licensed to the
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46018545
--- Diff: pom.xml ---
@@ -469,7 +475,11 @@
curator-client
${curator.version}
-
+
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46017732
--- Diff: external/storm-hdfs/pom.xml ---
@@ -103,6 +114,65 @@
+org.apache.hadoop
+
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46018085
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java
---
@@ -0,0 +1,379 @@
+/**
+ * Licensed to the
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46019946
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,444 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46020661
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46020723
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46022937
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46023183
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46022785
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46024038
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,296 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46022321
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46022397
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r46023394
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobSynchronizer.java
---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45896515
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,297 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45793192
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/KeySequenceNumber.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-159406843
backtype.storm.utils.Utils
```
535 try {
536 ReadableBlobMeta metadata = cb.getBlobMeta(key);
537 nimbusBlobVersion =
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45789303
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/KeySequenceNumber.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45789148
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/KeySequenceNumber.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45797735
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/KeySequenceNumber.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45789625
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/KeySequenceNumber.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45793730
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/KeySequenceNumber.java ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45800279
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,297 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-159413532
backtype.storm.utils.Utils
After an upmerge, it looks like we cleaned up some duplicate method
declarations. However, much of the remaining code is duplicated
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760156
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760606
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/IBlobWatcher.java ---
@@ -0,0 +1,25 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760644
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyFilter.java ---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760759
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760709
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760689
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760378
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java
---
@@ -0,0 +1,383 @@
+/**
+ * Licensed to the
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45759993
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760037
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45761222
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/LocalFsBlobStore.java
---
@@ -0,0 +1,306 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45759085
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -980,6 +980,126 @@
public static final String SUPERVISOR_SLOTS_PORTS =
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45759172
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -980,6 +980,126 @@
public static final String SUPERVISOR_SLOTS_PORTS =
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760187
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760253
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760346
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java
---
@@ -0,0 +1,383 @@
+/**
+ * Licensed to the
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760519
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/ClientBlobStore.java
---
@@ -0,0 +1,69 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760458
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java
---
@@ -0,0 +1,383 @@
+/**
+ * Licensed to the
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760493
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobSynchronizer.java
---
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760956
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45761185
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45759337
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/FileBlobStoreImpl.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760217
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760778
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45760787
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45582877
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/NimbusBlobStore.java
---
@@ -0,0 +1,419 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user bastiliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45583718
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/NimbusBlobStore.java
---
@@ -0,0 +1,419 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158974561
@d2r
396 struct ReadableBlobMeta {
397 1: required SettableBlobMeta settable;
398 //This is some indication of a version of a BLOB. The only guarantee
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158982859
> This blob version depends on the modified timestamp of the blob. The
versions or sequence numbers I hand over for nimbus HA are different as I have
written a KeyVersion
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45615908
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java
---
@@ -0,0 +1,383 @@
+/**
+ * Licensed to the
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45623407
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/FileBlobStoreImpl.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45624059
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,387 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45624346
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45624328
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45630920
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/FileBlobStoreImpl.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45624308
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,401 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45631509
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/FileBlobStoreImpl.java ---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45561155
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,387 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45561357
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,387 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45561354
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,387 @@
+/**
+ * Licensed to the Apache Software
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/845#issuecomment-158775737
@d2r Removed the config
/**
* Which implementation of {@link
backtype.storm.codedistributor.ICodeDistributor} should be used by storm for
code
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45494751
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45383300
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45384344
--- Diff: storm-core/src/jvm/backtype/storm/blobstore/BlobStore.java ---
@@ -0,0 +1,446 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45389791
--- Diff:
storm-core/src/jvm/backtype/storm/blobstore/BlobStoreAclHandler.java ---
@@ -0,0 +1,387 @@
+/**
+ * Licensed to the Apache Software Foundation
1 - 100 of 350 matches
Mail list logo
