Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1396#issuecomment-219340803
I don't think we can drop support for 1.x. If ES is not backward compatible
between 1.x and 2.x, we have to bear with supporting multiple versions though
it
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/1396#issuecomment-216858178
I have a similar PR (https://github.com/apache/storm/pull/1337) that keeps
Elastic 1.x and 2.x side by side to support both. Elastic Search 1.7 was
released just a few
Github user sweetest commented on the pull request:
https://github.com/apache/storm/pull/1396#issuecomment-216742378
I was also doing similar work, code change is almost the same. Looks good
to me!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user kojiisd opened a pull request:
https://github.com/apache/storm/pull/1396
[storm-elasticsearch]Upgrade elasticsearch version from 1.6.0 to 2.3.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kojiisd/storm 1.x-branch
