[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-161136973 NB +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user harshach commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-161149510 Thanks @ptgoetz merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/891 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user harshach commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-159672448 +1. Thanks this will make doc writing easier. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

+1. Cool. (However the pegdown doclet plugin for IDEA doesn't work -_-) On Thu, Nov 26, 2015 at 1:01 AM, harshach wrote: > Github user harshach commented on the pull request: > > https://github.com/apache/storm/pull/891#issuecomment-159672448 > > +1. Thanks this

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-159422903 **Note:** This pull request originally included the following commit: https://github.com/apache/storm/commit/e03b28ca6222f61471b4acb1a6086aab9b597b8a Earlier

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-159371834 I removed the highlight.js license from the source release LICENSE file since generated javadoc is not part of a source release. --- If your project is set up for it,

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-158086449 I am +1 on the concept. I don't see where highlight.js is added to the codebase. It is automatically inserted into the created javadocs? --- If your project is set up

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-158109736 @revans2 Yes, it is inserted into the generated HTML. Since javadoc isn't part of the source release, it probably only needs to be added to the LICENSE for the binary

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/891#issuecomment-157928854 Re: Merge conflicts, I'm happy to resolve therm at merge time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: STORM-1218: Use markdown for JavaDoc

GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/891 STORM-1218: Use markdown for JavaDoc JIRA: https://issues.apache.org/jira/browse/STORM-1218 This is a first pass at converting the JavaDoc in `storm-core` to markdown, using