Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-180221434
Forgot to leave comment, also backported to 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-180207678
Merged to master, backporting to 1.x-branch...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1026
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-180214818
Thanks @HeartSaVioR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-180204666
@abhishekagarwal87
Sorry to review in late. Looks good to me, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-176321658
can this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-175547593
Thank you. can you merge this into master and also select these commits for
backport onto 1.0 release?
---
If your project is set up for it, you can reply
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-175146222
Thanks @revans2 . Fixed the compilation error. I had missed some changes.
To put these changes in 1.0 release, do I need to open another pull request?
---
If
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-175148840
Typically you don't need a separate pull request. Just ask for it and we
will cherry-pick it. If there are merge conflicts we may come back and ask for
a separate
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-174012240
First of all travis saw a compilation failure.
```
[INFO] -
[ERROR] COMPILATION ERROR :
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-174013629
Other then that it looks OK to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user abhishekagarwal87 opened a pull request:
https://github.com/apache/storm/pull/1026
STORM-1455: Do not reset the emittedOffset for offsetOutOfRangeExceptions
There are two changes in this PR
- If there is a TopicOffsetOutOfRangeException, it can be due to an old
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1026#issuecomment-172904085
@HeartSaVioR @revans2 can you review these changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
13 matches
Mail list logo
