[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1076 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-19 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-186386735 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1116#discussion_r53500680 --- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj --- @@ -146,8 +146,10 @@ (logviewer-link host (event-logs-filename topology-id port)

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-18 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1116#issuecomment-185907734 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-17 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-185095359 @harshach Raised https://github.com/apache/storm/pull/1116 on 1.x branch . --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-16 Thread satishd
GitHub user satishd opened a pull request: https://github.com/apache/storm/pull/1116 STORM-1522 should create error worker log location only when error-hOst and error-port are available STORM-1522 should create error worker log location only when error-hOst and error-port are

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-16 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-185018994 @satishd can you open this up against 1.x-branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-10 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-182589360 Sounds good +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-180259693 +1 It doesn't affect UI (since no error occurs) but API still shows broken link, which let us feel odd. --- If your project is set up for it, you can reply to

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-04 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-180188920 when REST API (http://localhost:8080/api/v1/topology/{topology-name}) is used for getting topology details. It throws up spouts/bolts details like below which has wrong

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1076#issuecomment-179942647 The code looks OK to me, but I am a little confused about when would we get an invalid host or port for the error? The only time I can see is when we are doing a

[GitHub] storm pull request: STORM-1522 should create error worker log loca...

2016-02-03 Thread satishd
GitHub user satishd opened a pull request: https://github.com/apache/storm/pull/1076 STORM-1522 should create error worker log location only when error-host and error-port are available STORM-1522 should create error worker log location only when error-host and error-port are