[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-10 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-73822455 Let's close it for now.More information will be discussed on [STORM-654](https://issues.apache.org/jira/browse/STORM-654) --- If your project is set up for it, you c

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-10 Thread caofangkun
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-10 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-73770259 I am already planning on storing all the required information and modify the UI as part of nimbus HA, Please see https://issues.apache.org/jira/browse/STORM-654 a

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-10 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-73769844 I have a few questions. First why are we storing the nimbus version as JSON in zookeeper? The way the code is written to store the data in ZK we start off with the raw v

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/394#discussion_r24060605 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -18,12 +18,17 @@ [java.util Collections]) (:import [java.io FileN

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72782784 @caofangkun Thanks . I think it helps categorizing the configuration into different section. But in a storm deployment same storm.yaml used on all hosts. So I don't think

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/394#discussion_r24060103 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -18,12 +18,17 @@ [java.util Collections]) (:import [java.io FileNot

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72781055 @harshach Sorry for my unclear explanation.I am not ok with storing config in zk ether. I am just thinking storm config shoud be classfied to nimbus/supervis

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72780192 @revans2 @caofangkun Any reason to store storm config in zookeeper. I don't see any benefit of it and whenever user/admin changes storm config these needs to be updated

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72776924 @revans2 it might be good to: 1: the configuration should be paginated 2: we'd better supply three types of configuration and they may different from

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72770805 @revans2 Yes, not only nimbus server version numbers , but also supervisors and ui should show up version numbers on UI . In face , it may be better add supervs

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
GitHub user caofangkun reopened a pull request: https://github.com/apache/storm/pull/394 STORM-534:Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus like {nimbus_host_n

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72693402 @caofangkun If you want to reopen this and just add in the nimbus version information I would support that. --- If your project is set up for it, you can reply to this em

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72693203 Sorry this took me so long to respond to. I am kind of swamped :). I do like the idea of being able to access the version numbers for nimbus, but also for the supervisor

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-01-26 Thread caofangkun
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-01-25 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-71423079 @revans2 Could you please have a review on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-01-23 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/394 STORM-534:Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus like {nimbus_host_nam