[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1778 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-12-26 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r93867628 --- Diff: docs/storm-sql-reference.md --- @@ -1312,4 +1313,23 @@ You can use below as working reference for `--artifacts` option, and change depe

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-30 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r90187413 --- Diff: docs/storm-sql-reference.md --- @@ -1312,4 +1313,23 @@ You can use below as working reference for `--artifacts` option, and change depe

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87985904 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java --- @@ -0,0 +1,152 @@ +/*

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87985832 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/jvm/org/apache/storm/sql/hdfs/HdfsDataSourcesProvider.java --- @@ -0,0 +1,132 @@ +/* +

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87976945 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java --- @@ -0,0 +1,152 @@

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1778#discussion_r87973924 --- Diff: external/sql/storm-sql-external/storm-sql-hdfs/src/jvm/org/apache/storm/sql/hdfs/HdfsDataSourcesProvider.java --- @@ -0,0 +1,132 @@ +/*

[GitHub] storm pull request #1778: [STORM-2082][SQL] add sql external module storm-sq...

2016-11-15 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1778 [STORM-2082][SQL] add sql external module storm-sql-hdfs You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-2082