[GitHub] storm pull request #2526: STORM-2904: Document Metrics V2

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2526


---

[GitHub] storm pull request #2526: STORM-2904: Document Metrics V2

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2526#discussion_r163073567
  
--- Diff: docs/index.md ---
@@ -80,7 +80,7 @@ But small change will not affect the user experience. We 
will notify the user wh
 * [Distributed RPC](Distributed-RPC.html)
 * [Transactional topologies](Transactional-topologies.html)
 * [Hooks](Hooks.html)
-* [Metrics](Metrics.html)
+* [Metrics](metrics_v2.html)
--- End diff --

Maybe keeping deprecated metrics doc would help, though we would want to be 
clear that they're deprecated. 
There's explanation regarding built-in metrics in previous metrics doc, but 
it may look odd to get built-in metrics into metrics V2 doc, because only small 
set of metrics are available in metrics V2 while we don't migrate them. Users 
still need metrics V1 for them.


---

[GitHub] storm pull request #2526: STORM-2904: Document Metrics V2

[ptgoetz]

GitHub user ptgoetz opened a pull request:

https://github.com/apache/storm/pull/2526

STORM-2904: Document Metrics V2

Documentation only. No code changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptgoetz/storm metrics_v2_docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2526


commit 7239bbda655df48d263ccbfa298de871e1c07358
Author: P. Taylor Goetz 
Date:   2018-01-22T21:04:19Z

STORM-2904: Document Metrics V2




---