[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2554 ---

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167608762 --- Diff: storm-server/src/main/java/org/apache/storm/metricstore/WorkerMetricsProcessor.java --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167608546 --- Diff: storm-server/src/main/java/org/apache/storm/metricstore/WorkerMetricsProcessor.java --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167607557 --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java --- @@ -1040,6 +1039,13 @@ // and log an error message, so just validating

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2554#discussion_r167608078 --- Diff: storm-server/src/main/java/org/apache/storm/metricstore/MetricStoreConfig.java --- @@ -41,5 +41,23 @@ public static MetricStore configure(Map

[GitHub] storm pull request #2554: STORM-2939 add WorkerMetricsProcessor interface

2018-02-08 Thread agresch
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2554 STORM-2939 add WorkerMetricsProcessor interface This adds the WorkerMetricsProcessor interface. The default implementation executes the current code that sends metric data to Nimbus for insertion,