[GitHub] [streampipes] bossenti commented on a diff in pull request #1122: [#1121] Add replay once option to FileStreamProtocol

2023-01-20 Thread via GitHub
bossenti commented on code in PR #1122: URL: https://github.com/apache/streampipes/pull/1122#discussion_r1082919131 ## streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/protocol/stream/FileStreamProtocol.java: ## @@ -199,1

[GitHub] [streampipes] bossenti commented on a diff in pull request #1126: refactor: introduce messaging endpoint for python client

2023-01-20 Thread via GitHub
bossenti commented on code in PR #1126: URL: https://github.com/apache/streampipes/pull/1126#discussion_r1082948882 ## streampipes-client-python/streampipes_client/endpoint/endpoint.py: ## @@ -209,3 +212,76 @@ def get(self, identifier: str) -> Resource: ) ret

[GitHub] [streampipes] aamirxshaikh commented on pull request #1120: [#877] Format and lint core-ui module

2023-01-20 Thread via GitHub
aamirxshaikh commented on PR #1120: URL: https://github.com/apache/streampipes/pull/1120#issuecomment-1398817370 I have removed the commented code and updated the PR. @bossenti -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [streampipes] bossenti opened a new pull request, #1134: [#877] apply formatting and linting to login module

2023-01-20 Thread via GitHub
bossenti opened a new pull request, #1134: URL: https://github.com/apache/streampipes/pull/1134 ### Purpose Apply linting and formatting to the login module. ### Remarks PR introduces (a) breaking change(s): no PR introduces (a) deprecation(s):

[GitHub] [streampipes] dominikriemer opened a new pull request, #1135: Sp 1133

2023-01-20 Thread via GitHub
dominikriemer opened a new pull request, #1135: URL: https://github.com/apache/streampipes/pull/1135 ### Purpose Adds support to functions to create output data streams so that results of functions can be played back into StreamPipes. ### Remarks

[GitHub] [streampipes] bossenti commented on a diff in pull request #1135: Sp 1133

2023-01-20 Thread via GitHub
bossenti commented on code in PR #1135: URL: https://github.com/apache/streampipes/pull/1135#discussion_r1082988644 ## streampipes-config/src/main/java/org/apache/streampipes/config/backend/DefaultMessagingSettings.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [streampipes] bossenti opened a new pull request, #1136: [#877] apply formatting and linting to info module

2023-01-20 Thread via GitHub
bossenti opened a new pull request, #1136: URL: https://github.com/apache/streampipes/pull/1136 ### Purpose Applying formatting and linting to info module ### Remarks PR introduces (a) breaking change(s): no PR introduces (a) deprecation(s): no

[GitHub] [streampipes] bossenti opened a new pull request, #1137: [#877] apply formatting and linting to files module

2023-01-20 Thread via GitHub
bossenti opened a new pull request, #1137: URL: https://github.com/apache/streampipes/pull/1137 ### Purpose Apply formatting and linting to files module. ### Remarks PR introduces (a) breaking change(s): PR introduces (a) deprecation(s):

[GitHub] [streampipes] bossenti opened a new pull request, #1138: [#877] apply formatting and linting to editor module

2023-01-20 Thread via GitHub
bossenti opened a new pull request, #1138: URL: https://github.com/apache/streampipes/pull/1138 ### Purpose Apply formatting and linting for editor module. ### Remarks PR introduces (a) breaking change(s): no PR introduces (a) deprecation(s): no

[GitHub] [streampipes] bossenti opened a new pull request, #1139: [#877] apply formatting and linting to data-explorer module

2023-01-20 Thread via GitHub
bossenti opened a new pull request, #1139: URL: https://github.com/apache/streampipes/pull/1139 ### Purpose Apply formatting and linting to data-explorer module. ### Remarks PR introduces (a) breaking change(s): no PR introduces (a) deprecation(

[GitHub] [streampipes] dominikriemer opened a new pull request, #1141: Redirect to previous view after successful login (#1140)

2023-01-20 Thread via GitHub
dominikriemer opened a new pull request, #1141: URL: https://github.com/apache/streampipes/pull/1141 ### Purpose Users are redirected to a child route after requesting a route without proper login credential and successful login. ### Remarks PR in

[GitHub] [streampipes] Harry262530 opened a new pull request, #1142: pull request for auto pr labeler

2023-01-20 Thread via GitHub
Harry262530 opened a new pull request, #1142: URL: https://github.com/apache/streampipes/pull/1142 ### Purpose ### Remarks PR introduces (a) breaking change(s): PR introduces (a) deprecation(s): -- This is an automated message from the Apa

[GitHub] [streampipes] tenthe commented on a diff in pull request #1137: [#877] apply formatting and linting to files module

2023-01-21 Thread via GitHub
tenthe commented on code in PR #1137: URL: https://github.com/apache/streampipes/pull/1137#discussion_r1083264526 ## ui/src/app/files/components/file-overview/file-overview.component.scss: ## @@ -17,24 +17,24 @@ */ .mat-table { - //background: #FAFAFA; +//background: #

[GitHub] [streampipes] tenthe merged pull request #1120: [#877] Format and lint core-ui module

2023-01-21 Thread via GitHub
tenthe merged PR #1120: URL: https://github.com/apache/streampipes/pull/1120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes

[GitHub] [streampipes] tenthe commented on a diff in pull request #1122: [#1121] Add replay once option to FileStreamProtocol

2023-01-21 Thread via GitHub
tenthe commented on code in PR #1122: URL: https://github.com/apache/streampipes/pull/1122#discussion_r1083265528 ## streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/protocol/stream/FileStreamProtocol.java: ## @@ -199,10

[GitHub] [streampipes] bossenti commented on a diff in pull request #1122: [#1121] Add replay once option to FileStreamProtocol

2023-01-21 Thread via GitHub
bossenti commented on code in PR #1122: URL: https://github.com/apache/streampipes/pull/1122#discussion_r1083270693 ## streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/protocol/stream/FileStreamProtocol.java: ## @@ -199,1

[GitHub] [streampipes] bossenti merged pull request #1134: [#877] apply formatting and linting to login module

2023-01-21 Thread via GitHub
bossenti merged PR #1134: URL: https://github.com/apache/streampipes/pull/1134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083271649 ## .github/prlabeller.yml: ## @@ -0,0 +1,21 @@ +# Add repo label to any change in any file Review Comment: This is just the example config from the GitHub acti

[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
Harry262530 commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083273920 ## .github/prlabeller.yml: ## @@ -0,0 +1,21 @@ +# Add repo label to any change in any file Review Comment: yah, basically i was trying to give at least o

[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
Harry262530 commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274037 ## .github/workflows/prlabelling.yaml: ## @@ -0,0 +1,16 @@ +name: "Pull Request Labeler" +run-name: ${{ github.actor }} created Pull Request Labeler + +on: +- p

[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
Harry262530 commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274176 ## config_merge.yml: ## @@ -0,0 +1,18 @@ +name: 'PRLabeler' Review Comment: actually for the past 1 day i studied about pull request and labels so I saw th

[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274194 ## .github/workflows/prlabelling.yaml: ## @@ -0,0 +1,16 @@ +name: "Pull Request Labeler" +run-name: ${{ github.actor }} created Pull Request Labeler + +on: +- pull

[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
Harry262530 commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274304 ## .github/workflows/prlabelling.yaml: ## @@ -0,0 +1,16 @@ +name: "Pull Request Labeler" +run-name: ${{ github.actor }} created Pull Request Labeler + +on: +- p

[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274439 ## .github/prlabeller.yml: ## @@ -0,0 +1,21 @@ +# Add repo label to any change in any file Review Comment: I see, but we don't use such a label You can find

[GitHub] [streampipes] bossenti merged pull request #1136: [#877] apply formatting and linting to info module

2023-01-21 Thread via GitHub
bossenti merged PR #1136: URL: https://github.com/apache/streampipes/pull/1136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274659 ## config_merge.yml: ## @@ -0,0 +1,18 @@ +name: 'PRLabeler' Review Comment: Can you provide me with an example? -- This is an automated message from the Ap

[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274659 ## config_merge.yml: ## @@ -0,0 +1,18 @@ +name: 'PRLabeler' Review Comment: Can you provide me with a link to an example? -- This is an automated message f

[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
Harry262530 commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083274910 ## .github/prlabeller.yml: ## @@ -0,0 +1,21 @@ +# Add repo label to any change in any file Review Comment: sure, i will try my level best -- This is

[GitHub] [streampipes] Harry262530 commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
Harry262530 commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083275393 ## .github/workflows/prlabelling.yaml: ## @@ -0,0 +1,16 @@ +name: "Pull Request Labeler" +run-name: ${{ github.actor }} created Pull Request Labeler + +on: +- p

[GitHub] [streampipes-website] bossenti opened a new pull request, #56: traget help link on download page to Github discussions

2023-01-21 Thread via GitHub
bossenti opened a new pull request, #56: URL: https://github.com/apache/streampipes-website/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-21 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083291525 ## .github/workflows/prlabelling.yaml: ## @@ -0,0 +1,16 @@ +name: "Pull Request Labeler" +run-name: ${{ github.actor }} created Pull Request Labeler + +on: +- pull

[GitHub] [streampipes] bossenti merged pull request #1137: [#877] apply formatting and linting to files module

2023-01-22 Thread via GitHub
bossenti merged PR #1137: URL: https://github.com/apache/streampipes/pull/1137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] aamirxshaikh opened a new pull request, #1144: [#877] Format and lint CustomMaterial module

2023-01-22 Thread via GitHub
aamirxshaikh opened a new pull request, #1144: URL: https://github.com/apache/streampipes/pull/1144 ### Purpose Applying UI linting and formatting to the `CustomMaterial` module. Removing the `CustomMaterial` module from `ui/.eslintignore` and `ui/.prettierigno

[GitHub] [streampipes-website] bossenti merged pull request #56: traget help link on download page to Github discussions

2023-01-22 Thread via GitHub
bossenti merged PR #56: URL: https://github.com/apache/streampipes-website/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@strea

[GitHub] [streampipes] dominikriemer merged pull request #1141: Redirect to previous view after successful login (#1140)

2023-01-22 Thread via GitHub
dominikriemer merged PR #1141: URL: https://github.com/apache/streampipes/pull/1141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stre

[GitHub] [streampipes] bossenti commented on pull request #1144: [#877] Format and lint CustomMaterial module

2023-01-22 Thread via GitHub
bossenti commented on PR #1144: URL: https://github.com/apache/streampipes/pull/1144#issuecomment-1399887816 Do we want to rename the module to `custom-material` @tenthe @dominikriemer? Would be consistent with the other module names -- This is an automated message from the Apache Git Ser

[GitHub] [streampipes] tenthe commented on pull request #1144: [#877] Format and lint CustomMaterial module

2023-01-22 Thread via GitHub
tenthe commented on PR #1144: URL: https://github.com/apache/streampipes/pull/1144#issuecomment-1399914010 Yes, I think that is a good idea. We should also discuss if we still need this module. We should address the question whether it is good practice to make all dependencies into one m

[GitHub] [streampipes] bossenti commented on pull request #1144: [#877] Format and lint CustomMaterial module

2023-01-23 Thread via GitHub
bossenti commented on PR #1144: URL: https://github.com/apache/streampipes/pull/1144#issuecomment-1399935930 👍🏼 But that's a follow-up topic right? 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [streampipes] dominikriemer commented on a diff in pull request #1135: Sp 1133

2023-01-23 Thread via GitHub
dominikriemer commented on code in PR #1135: URL: https://github.com/apache/streampipes/pull/1135#discussion_r1083757522 ## streampipes-config/src/main/java/org/apache/streampipes/config/backend/DefaultMessagingSettings.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache So

[GitHub] [streampipes] tenthe commented on pull request #1144: [#877] Format and lint CustomMaterial module

2023-01-23 Thread via GitHub
tenthe commented on PR #1144: URL: https://github.com/apache/streampipes/pull/1144#issuecomment-1400300905 Yes, that is a follow up topic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [streampipes] dominikriemer merged pull request #1135: Sp 1133

2023-01-23 Thread via GitHub
dominikriemer merged PR #1135: URL: https://github.com/apache/streampipes/pull/1135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stre

[GitHub] [streampipes] tenthe merged pull request #1122: [#1121] Add replay once option to FileStreamProtocol

2023-01-23 Thread via GitHub
tenthe merged PR #1122: URL: https://github.com/apache/streampipes/pull/1122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes

[GitHub] [streampipes] bossenti merged pull request #1145: Bump @angular-eslint/template-parser from 15.1.0 to 15.2.0 in /ui

2023-01-23 Thread via GitHub
bossenti merged PR #1145: URL: https://github.com/apache/streampipes/pull/1145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti merged pull request #1126: refactor: introduce messaging endpoint for python client

2023-01-23 Thread via GitHub
bossenti merged PR #1126: URL: https://github.com/apache/streampipes/pull/1126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti opened a new pull request, #1147: refactor: further clean up python data model & introduce function definition

2023-01-23 Thread via GitHub
bossenti opened a new pull request, #1147: URL: https://github.com/apache/streampipes/pull/1147 ### Purpose This PR contains some minor refactorings: * improve import paths of `broker`-classes * restructure python model and reduce usage of `BaseElement` class

[GitHub] [streampipes] bossenti opened a new pull request, #1149: Extend REST API by endpoint to get a specific function definition

2023-01-23 Thread via GitHub
bossenti opened a new pull request, #1149: URL: https://github.com/apache/streampipes/pull/1149 ### Purpose Extend the REST API by the endpoint `/v2/functions/` that returns the definition of the given function. ### Remarks PR introduces (a) breaking

[GitHub] [streampipes] bossenti commented on pull request #1138: [#877] apply formatting and linting to editor module

2023-01-23 Thread via GitHub
bossenti commented on PR #1138: URL: https://github.com/apache/streampipes/pull/1138#issuecomment-1400849033 @tenthe can you provide me with some help for the failing e2e tests? (same for the other PR) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [streampipes] bossenti commented on pull request #1130: Bump proton-j from 0.30.0 to 0.34.0

2023-01-23 Thread via GitHub
bossenti commented on PR #1130: URL: https://github.com/apache/streampipes/pull/1130#issuecomment-1400951497 Removed `proton-j` since no usage discernible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [streampipes] bossenti commented on pull request #1131: Bump javapoet from 1.6.1 to 1.13.0

2023-01-23 Thread via GitHub
bossenti commented on PR #1131: URL: https://github.com/apache/streampipes/pull/1131#issuecomment-1400952061 Removed `javapoet` since no usage is discernible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [streampipes] tenthe opened a new pull request, #1153: Sp 1132: Replace FileSet adapters with FileStream adapters in all e2e tests

2023-01-23 Thread via GitHub
tenthe opened a new pull request, #1153: URL: https://github.com/apache/streampipes/pull/1153 ### Purpose This PR fixes #1132 by removing all File Set adapter references and replacing them with a file stream adapter ### Remarks PR introduces (a) break

[GitHub] [streampipes] bossenti merged pull request #1150: Bump blacken-docs from 1.12.1 to 1.13.0 in /streampipes-client-python

2023-01-23 Thread via GitHub
bossenti merged PR #1150: URL: https://github.com/apache/streampipes/pull/1150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti commented on pull request #1151: Bump pre-commit from 2.21.0 to 3.0.0 in /streampipes-client-python

2023-01-23 Thread via GitHub
bossenti commented on PR #1151: URL: https://github.com/apache/streampipes/pull/1151#issuecomment-1401509049 We first need to check if we need to provide the migration config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [streampipes] tenthe commented on pull request #1130: Bump proton-j from 0.30.0 to 0.34.0

2023-01-24 Thread via GitHub
tenthe commented on PR #1130: URL: https://github.com/apache/streampipes/pull/1130#issuecomment-1401630115 It seems that the `proton-j` dependency is required to resolve the dependency convergence in `streampipes-pipeline-elements-data-simulator` -- This is an automated message from the A

[GitHub] [streampipes] bossenti commented on pull request #1149: Extend REST API by endpoint to get a specific function definition

2023-01-24 Thread via GitHub
bossenti commented on PR #1149: URL: https://github.com/apache/streampipes/pull/1149#issuecomment-1401652719 What would happen if I query by an unknown id? Would this result in an internal exception or does the framework catch the exception and return a proper API response? -- This is an

[GitHub] [streampipes] tenthe commented on pull request #1149: Extend REST API by endpoint to get a specific function definition

2023-01-24 Thread via GitHub
tenthe commented on PR #1149: URL: https://github.com/apache/streampipes/pull/1149#issuecomment-1401667024 That is a good point. How could we test it properly? I guess the best way would be to mock `FunctionRegistrationService.INSTANCE` but since it is an enum I am not sure if it is easil

[GitHub] [streampipes] tenthe merged pull request #1144: [#877] Format and lint CustomMaterial module

2023-01-24 Thread via GitHub
tenthe merged PR #1144: URL: https://github.com/apache/streampipes/pull/1144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes

[GitHub] [streampipes] SvenO3 commented on pull request #1147: refactor: further clean up python data model & introduce function definition

2023-01-24 Thread via GitHub
SvenO3 commented on PR #1147: URL: https://github.com/apache/streampipes/pull/1147#issuecomment-1401809246 I also work on the python functions at the moment and try to support output data streams like in Java (see #1135). So I am changing the data model and definition of a function too, but

[GitHub] [streampipes] SvenO3 commented on a diff in pull request #1147: refactor: further clean up python data model & introduce function definition

2023-01-24 Thread via GitHub
SvenO3 commented on code in PR #1147: URL: https://github.com/apache/streampipes/pull/1147#discussion_r1085223742 ## streampipes-client-python/streampipes_client/model/common.py: ## @@ -55,30 +55,33 @@ class BaseElement(BasicModel): element_id: Optional[StrictStr] -clas

[GitHub] [streampipes] bossenti commented on a diff in pull request #1147: refactor: further clean up python data model & introduce function definition

2023-01-24 Thread via GitHub
bossenti commented on code in PR #1147: URL: https://github.com/apache/streampipes/pull/1147#discussion_r1085242291 ## streampipes-client-python/streampipes_client/model/common.py: ## @@ -55,30 +55,33 @@ class BaseElement(BasicModel): element_id: Optional[StrictStr] -cl

[GitHub] [streampipes] bossenti commented on pull request #1147: refactor: further clean up python data model & introduce function definition

2023-01-24 Thread via GitHub
bossenti commented on PR #1147: URL: https://github.com/apache/streampipes/pull/1147#issuecomment-1401857395 @SvenO3 cool 🤩 Then let's align on this somewhen in the near future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [streampipes] bossenti commented on a diff in pull request #1153: Sp 1132: Replace FileSet adapters with FileStream adapters in all e2e tests

2023-01-24 Thread via GitHub
bossenti commented on code in PR #1153: URL: https://github.com/apache/streampipes/pull/1153#discussion_r1085391741 ## ui/cypress/fixtures/connect/aggregationRules/expected.csv: ## @@ -1,2 +0,0 @@ -timestamp;value Review Comment: Is this file intended to be empty? -- Thi

[GitHub] [streampipes] tenthe commented on a diff in pull request #1153: Sp 1132: Replace FileSet adapters with FileStream adapters in all e2e tests

2023-01-24 Thread via GitHub
tenthe commented on code in PR #1153: URL: https://github.com/apache/streampipes/pull/1153#discussion_r1085399857 ## ui/cypress/fixtures/connect/aggregationRules/expected.csv: ## @@ -1,2 +0,0 @@ -timestamp;value Review Comment: Unfortunately, yes ;) Thanks for the Review

[GitHub] [streampipes] tenthe merged pull request #1153: Sp 1132: Replace FileSet adapters with FileStream adapters in all e2e tests

2023-01-24 Thread via GitHub
tenthe merged PR #1153: URL: https://github.com/apache/streampipes/pull/1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes

[GitHub] [streampipes] aamirxshaikh opened a new pull request, #1154: [#877] Format and lint dashboard module

2023-01-24 Thread via GitHub
aamirxshaikh opened a new pull request, #1154: URL: https://github.com/apache/streampipes/pull/1154 ### Purpose Applying UI linting and formatting to the `dashboard` module. Removing the `dashboard` module from `ui/.eslintignore` and `ui/.prettierignore` and fi

[GitHub] [streampipes] yash013 opened a new pull request, #1155: remove dependencies and add css for datatable.

2023-01-24 Thread via GitHub
yash013 opened a new pull request, #1155: URL: https://github.com/apache/streampipes/pull/1155 removed these dependencies - angular-datatables - datatables.net - datatables.net-dt added CSS for the DataTable in HelpComponent. -- This is an automated message from the Apache

[GitHub] [streampipes] dominikriemer commented on a diff in pull request #1155: remove dependencies and add css for datatable.

2023-01-24 Thread via GitHub
dominikriemer commented on code in PR #1155: URL: https://github.com/apache/streampipes/pull/1155#discussion_r1085827659 ## ui/src/app/editor/dialog/help/help.component.html: ## @@ -16,6 +16,29 @@ ~ --> + +/* .table { +margin: 20px 0; +font-size: 0.9e

[GitHub] [streampipes] tenthe commented on pull request #1155: remove dependencies and add css for datatable.

2023-01-24 Thread via GitHub
tenthe commented on PR #1155: URL: https://github.com/apache/streampipes/pull/1155#issuecomment-1402579495 Thank you very much for the PR. Can you please move the css code directly into the .scss file as @dominikriemer mentioned. -- This is an automated message from the Apache Git Serv

[GitHub] [streampipes] tenthe commented on pull request #1130: Bump proton-j from 0.30.0 to 0.34.0

2023-01-24 Thread via GitHub
tenthe commented on PR #1130: URL: https://github.com/apache/streampipes/pull/1130#issuecomment-1402612345 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [streampipes] yash013 commented on a diff in pull request #1155: remove dependencies and add css for datatable.

2023-01-24 Thread via GitHub
yash013 commented on code in PR #1155: URL: https://github.com/apache/streampipes/pull/1155#discussion_r1085910836 ## ui/src/app/editor/dialog/help/help.component.html: ## @@ -16,6 +16,29 @@ ~ --> + +/* .table { +margin: 20px 0; +font-size: 0.9em; +

[GitHub] [streampipes] tenthe merged pull request #1130: Bump proton-j from 0.30.0 to 0.34.0

2023-01-24 Thread via GitHub
tenthe merged PR #1130: URL: https://github.com/apache/streampipes/pull/1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes

[GitHub] [streampipes] tenthe merged pull request #1131: Bump javapoet from 1.6.1 to 1.13.0

2023-01-24 Thread via GitHub
tenthe merged PR #1131: URL: https://github.com/apache/streampipes/pull/1131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes

[GitHub] [streampipes] tenthe commented on pull request #1152: Bump @angular-eslint/eslint-plugin from 15.1.0 to 15.2.0 in /ui

2023-01-24 Thread via GitHub
tenthe commented on PR #1152: URL: https://github.com/apache/streampipes/pull/1152#issuecomment-1403133780 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [streampipes] tenthe commented on pull request #1155: remove dependencies and add css for datatable.

2023-01-24 Thread via GitHub
tenthe commented on PR #1155: URL: https://github.com/apache/streampipes/pull/1155#issuecomment-1403201816 Thanks for the update! I had a look at the PR and have some minor comments: - Did StreamPipes start for you? - I had to remove `"node_modules/datatables.net/js/jquery.dataTa

[GitHub] [streampipes] tenthe merged pull request #1156: Bump ua-parser-js from 0.7.32 to 0.7.33 in /ui

2023-01-24 Thread via GitHub
tenthe merged PR #1156: URL: https://github.com/apache/streampipes/pull/1156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes

[GitHub] [streampipes] yash013 commented on pull request #1155: remove dependencies and add css for datatable.

2023-01-24 Thread via GitHub
yash013 commented on PR #1155: URL: https://github.com/apache/streampipes/pull/1155#issuecomment-1403224145 sure. i will do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [streampipes] yash013 commented on pull request #1155: remove dependencies and add css for datatable.

2023-01-25 Thread via GitHub
yash013 commented on PR #1155: URL: https://github.com/apache/streampipes/pull/1155#issuecomment-1403385345 i was adding some css to the preview.component but it is not working .That changes worked in HelpComponent. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [streampipes] bossenti merged pull request #1152: Bump @angular-eslint/eslint-plugin from 15.1.0 to 15.2.0 in /ui

2023-01-25 Thread via GitHub
bossenti merged PR #1152: URL: https://github.com/apache/streampipes/pull/1152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] tenthe commented on pull request #1155: remove dependencies and add css for datatable.

2023-01-25 Thread via GitHub
tenthe commented on PR #1155: URL: https://github.com/apache/streampipes/pull/1155#issuecomment-1403697493 Did you add it to this file? `./pipeline-element-runtime-info.component.scss` The table for the priview should be located in `connect/components/runtime-info/pipeline-element-runtime

[GitHub] [streampipes] bossenti commented on pull request #1151: Bump pre-commit from 2.21.0 to 3.0.0 in /streampipes-client-python

2023-01-25 Thread via GitHub
bossenti commented on PR #1151: URL: https://github.com/apache/streampipes/pull/1151#issuecomment-1404035688 No need to migrate the config in our case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [streampipes] bossenti commented on pull request #1151: Bump pre-commit from 2.21.0 to 3.0.0 in /streampipes-client-python

2023-01-25 Thread via GitHub
bossenti commented on PR #1151: URL: https://github.com/apache/streampipes/pull/1151#issuecomment-1404036008 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [streampipes] bossenti merged pull request #1139: [#877] apply formatting and linting to data-explorer module

2023-01-25 Thread via GitHub
bossenti merged PR #1139: URL: https://github.com/apache/streampipes/pull/1139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti merged pull request #1154: [#877] Format and lint dashboard module

2023-01-25 Thread via GitHub
bossenti merged PR #1154: URL: https://github.com/apache/streampipes/pull/1154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti merged pull request #1138: [#877] apply formatting and linting to editor module

2023-01-25 Thread via GitHub
bossenti merged PR #1138: URL: https://github.com/apache/streampipes/pull/1138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti merged pull request #1149: Extend REST API by endpoint to get a specific function definition

2023-01-25 Thread via GitHub
bossenti merged PR #1149: URL: https://github.com/apache/streampipes/pull/1149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti merged pull request #1151: Bump pre-commit from 2.21.0 to 3.0.0 in /streampipes-client-python

2023-01-25 Thread via GitHub
bossenti merged PR #1151: URL: https://github.com/apache/streampipes/pull/1151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti merged pull request #1147: refactor: further clean up python data model & introduce function definition

2023-01-25 Thread via GitHub
bossenti merged PR #1147: URL: https://github.com/apache/streampipes/pull/1147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-25 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r108713 ## .github/pr-labeler-config.yml: ## @@ -0,0 +1,46 @@ +backend: +# TODO Review Comment: @tenthe @dominikriemer what do you think we should provide here? --

[GitHub] [streampipes] bossenti commented on pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-25 Thread via GitHub
bossenti commented on PR #1142: URL: https://github.com/apache/streampipes/pull/1142#issuecomment-1404279104 @tenthe @dominikriemer I came with an initial version of the label config Although, I'm not really user whether all these file path filters will work, I would just give it a try

[GitHub] [streampipes] dominikriemer commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

2023-01-26 Thread via GitHub
dominikriemer commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1087521805 ## .github/pr-labeler-config.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

[GitHub] [streampipes] dominikriemer opened a new pull request, #1163: Update GitHub notification settings (#1162)

2023-01-26 Thread via GitHub
dominikriemer opened a new pull request, #1163: URL: https://github.com/apache/streampipes/pull/1163 ### Purpose Better organize mail on the mailing lists by rewriting mail subjects of GitHub mails. ### Remarks PR introduces (a) breaking change(s)

[GitHub] [streampipes] bossenti merged pull request #1160: Bump lz4-java from 1.7.1 to 1.8.0

2023-01-26 Thread via GitHub
bossenti merged PR #1160: URL: https://github.com/apache/streampipes/pull/1160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] bossenti merged pull request #1161: Bump @angular-eslint/eslint-plugin-template from 15.1.0 to 15.2.0 in /ui

2023-01-26 Thread via GitHub
bossenti merged PR #1161: URL: https://github.com/apache/streampipes/pull/1161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampip

[GitHub] [streampipes] obermeier opened a new pull request, #1165: fix #1164

2023-01-26 Thread via GitHub
obermeier opened a new pull request, #1165: URL: https://github.com/apache/streampipes/pull/1165 fix #1164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [streampipes] dominikriemer merged pull request #1163: Update GitHub notification settings (#1162)

2023-01-26 Thread via GitHub
dominikriemer merged PR #1163: URL: https://github.com/apache/streampipes/pull/1163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stre

[PR] [#1146] Session based implementation of IoTDB sink (fix issues in current JDBC based implementation) (streampipes)

2023-01-26 Thread via GitHub
SteveYurongSu opened a new pull request, #1166: URL: https://github.com/apache/streampipes/pull/1166 ### Purpose Recently, I was trying to play around streampipes and found that iotdb sink could not work properly. I checked the source code and found that the

Re: [PR] [#1146] Session based implementation of IoTDB sink (fix issues in current JDBC based implementation) (streampipes)

2023-01-26 Thread via GitHub
bossenti commented on PR #1166: URL: https://github.com/apache/streampipes/pull/1166#issuecomment-1405411871 @SteveYurongSu Thank you so much for this awesome contribution 🙏🏼 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [#1104] add GitHub workflow to label PRs automatically (streampipes)

2023-01-26 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1088195357 ## .github/pr-labeler-config.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

Re: [PR] [#1104] add GitHub workflow to label PRs automatically (streampipes)

2023-01-26 Thread via GitHub
bossenti commented on code in PR #1142: URL: https://github.com/apache/streampipes/pull/1142#discussion_r1088195897 ## .github/pr-labeler-config.yml: ## @@ -0,0 +1,46 @@ +backend: +# TODO Review Comment: Had the same idea, I'll have a look if the config's syntax allows for t

[PR] refactor: remove outdated readme files (streampipes)

2023-01-26 Thread via GitHub
bossenti opened a new pull request, #1167: URL: https://github.com/apache/streampipes/pull/1167 ### Purpose This PR removes two outdated README files that are probably left-overs from including other StreamPipes repos in to the main one. ### Remarks P

[PR] [#792] rename python client to `streampipes-client` (streampipes)

2023-01-26 Thread via GitHub
bossenti opened a new pull request, #1168: URL: https://github.com/apache/streampipes/pull/1168 ### Purpose Rename the package name of the python client to `streampipes-client` ### Remarks PR introduces (a) breaking change(s): no (not yet) PR in

  1   2   3   4   5   6   7   8   9   10   >