[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread smashew
Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12304252 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java --- @@ -166,19

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread smashew
Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12302402 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3PersistReaderTask.java --- @@ -0,0 +1,87 @@

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12302487 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3PersistWriterTask.java --- @@ -0,0 +1,37 @@

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread smashew
Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12302410 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3ObjectInputStreamWrapper.java --- @@ -0,0

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12303430 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterUserInformationProvider.java --- @@

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12303349 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterUserInformationProvider.java --- @@

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12301958 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3PersistReader.java --- @@ -0,0 +1,141 @@

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12303753 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3Configurator.java --- @@ -0,0 +1,64 @@

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12301124 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3ObjectInputStreamWrapper.java --- @@ -0,0

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread smashew
Github user smashew commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12301806 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3ObjectInputStreamWrapper.java --- @@ -0,0

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread smashew
Github user smashew commented on the pull request: https://github.com/apache/incubator-streams/pull/8#issuecomment-42237930 To play devil's advocate, by that logic, one could just have one single configuration for everything in streams and an enum that could delegate the parameters

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12300490 --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3Configurator.java --- @@ -0,0 +1,64 @@

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/8#issuecomment-42300470 Since it is such a large patch, I will give everyone in the community more time to review before committing. If there are no other comments before Thursday,

[GitHub] incubator-streams pull request: STREAMS-72 - Updated Elasticsearch...

2014-05-06 Thread mfranklin
Github user mfranklin commented on the pull request: https://github.com/apache/incubator-streams/pull/7#issuecomment-42300533 This was posted over 3 days ago, so if there are no comments before the end of the day, I will commit. --- If your project is set up for it, you can reply to

[GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread mfranklin
Github user mfranklin commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/8#discussion_r12323298 --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StatusCounterMonitorRunnable.java --- @@ -0,0 +1,6

Re: Proposing Changes to the StreamsProvider interface and StreamsProviderTask

2014-05-06 Thread Matt Franklin
On Mon, May 5, 2014 at 1:15 PM, Steve Blackmon sblack...@apache.org wrote: What I meant to say re #1 below is that batch-level metadata could be useful for modules downstream of the StreamsProvider / StreamsPersistReader, and the StreamsResultSet gives us a class to which we can add new

[jira] [Commented] (STREAMS-72) ElasticsearchPersistWriter fails to flush low volume streams

2014-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STREAMS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990625#comment-13990625 ] ASF GitHub Bot commented on STREAMS-72: --- Github user mfranklin commented on the pull

Re: [GitHub] incubator-streams pull request: Twitter Modificaitons

2014-05-06 Thread Matthew Hager [W2O Digital]
I actually thought about that name myself, because of the name of the derived classes I had a large internal debate. I am amicable to any name anyone could want. Sent from my iPhone On May 6, 2014, at 8:22 AM, mfranklin g...@git.apache.org wrote: Github user mfranklin commented on a diff

[GitHub] incubator-streams pull request: Streams 33

2014-05-06 Thread steveblackmon
Github user steveblackmon commented on the pull request: https://github.com/apache/incubator-streams/pull/11#issuecomment-42322377 sorry, wrong upstream --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-streams pull request: Streams 33

2014-05-06 Thread steveblackmon
GitHub user steveblackmon opened a pull request: https://github.com/apache/incubator-streams/pull/11 Streams 33 You can merge this pull request into a Git repository by running: $ git pull https://github.com/w2ogroup/incubator-streams STREAMS-33 Alternatively you can review

[GitHub] incubator-streams pull request: STREAMS-60, STREAMS-70

2014-05-06 Thread steveblackmon
GitHub user steveblackmon opened a pull request: https://github.com/apache/incubator-streams/pull/12 STREAMS-60, STREAMS-70 You can merge this pull request into a Git repository by running: $ git pull https://github.com/w2ogroup/incubator-streams STREAMS-60 Alternatively you

[GitHub] incubator-streams pull request: STREAMS-72 - Updated Elasticsearch...

2014-05-06 Thread steveblackmon
Github user steveblackmon commented on the pull request: https://github.com/apache/incubator-streams/pull/7#issuecomment-42365744 are there any changes required to applications or application configurations using LocalStreamBuilder to ensure they continue to work as before after