Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r17048015
--- Diff:
streams-contrib/streams-provider-facebook/metadata/facebook_post.mup ---
@@ -0,0 +1,694 @@
+{
--- End diff --
OK. I
Matt Franklin created STREAMS-161:
-
Summary: StreamsProviderTask reports isRunning() == true when
exception occurs in StreamsProvider.startStream()
Key: STREAMS-161
URL:
[
https://issues.apache.org/jira/browse/STREAMS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Franklin resolved STREAMS-161.
---
Resolution: Fixed
StreamsProviderTask reports isRunning() == true when exception occurs in
Samza has excellent developer guidelines we could use for inspiration:
http://samza.incubator.apache.org/contribute/rules.html
http://samza.incubator.apache.org/contribute/coding-guide.html
I am in favor of testing, but skeptical of testing just for the sake
of having a test. How about someone
Matt - Great suggestion. We should get this all documented and added to
the webpage with a general 'how to contribute' along with guidelines.
Steve - No testing should be 'testing just for the sake of having a test'.
There needs to be tests to verify that the logic in all contributed code
is
