RE: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Jason Pyeron
> -Original Message- > From: Dave Newton [mailto:[email protected]] > Sent: Wednesday, May 18, 2011 20:10 > To: Struts Developers List > Subject: Re: Issue Reporting: problem with findRootObject > process in struts2-json-plugin-2.2.3.jar > > On Wednesday, May 18, 2011, Jerry Yuan wro

Re: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Dave Newton
On Wednesday, May 18, 2011, Jerry Yuan wrote: > Any suggestions about placing it somewhere other than stack? Relying on stack position will always create risk, as you assume nothing else will ever modify the stack, and there is little communication to other layers or interceptors that the informat

Re: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Chris Pratt
Sorry, I didn't have my reference near me before, try this: invocation.getStack().getContext().put("myObj",x); (*Chris*) On Wed, May 18, 2011 at 3:28 PM, Jerry Yuan wrote: > Thanks for the information, we don't have to put the data on the top of the > stack, but we cannot do a stack.p

RE: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Jerry Yuan
That is a good point. Placing it on the stack should not be the only approach, but our application uses the interceptor to get the skin from incoming url and use it in the action and freemarker templates, and using interceptors to push it onto the stack seems to be the way we have currently adop

Re: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Dave Newton
On Wed, May 18, 2011 at 6:28 PM, Jerry Yuan wrote: > Our interceptor needs to place the information holder such as skin > holder into the stack before calling the action class [...] Why does it have to place it specifically on the stack? Dave

RE: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Jerry Yuan
Thanks for the information, we don't have to put the data on the top of the stack, but we cannot do a stack.put("myObj", x) since ValueStack doesn't have the put method besides push. Our interceptor needs to place the information holder such as skin holder into the stack before calling the actio

RE: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Chris Pratt
I believe that was the entire purpose of the change. To allow interceptors (especially the ModelDriven interceptor) to provide the data for a JSON result. Do your interceptors have to put the data on the top of the stack? You could just do a stack.put("myObj",x) instead of a stack.push(x), then

RE: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Jerry Yuan
A concrete example would be: if there are interceptors implemented before the actions get called, the interceptors push information holders into the stack, and whatever the interceptors push to the stack will be first pulled off by the peek process in the statement "rootObject = invocation.getSt

RE: Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Jason Pyeron
> -Original Message- > From: Jerry Yuan [mailto:[email protected]] > Sent: Wednesday, May 18, 2011 16:40 > To: '[email protected]' > Subject: Issue Reporting: problem with findRootObject process > in struts2-json-plugin-2.2.3.jar > > We have just upgraded our applications from St

Issue Reporting: problem with findRootObject process in struts2-json-plugin-2.2.3.jar

2011-05-18 Thread Jerry Yuan
We have just upgraded our applications from Struts 2.2.1 into Struts 2.2.3 (which was released on May 9, 2011). We saw and identified an issue in our application after the upgrade, and the issue exists in the library struts2-json-plugin-2.2.3.jar. Basically in the class org.apache.struts2.json.