struts2 pull request: Update project.xml

2013-06-13 Thread chengcheng222e
GitHub user chengcheng222e opened a pull request: https://github.com/apache/struts2/pull/7 Update project.xml nothing to do . just test the github . I am very sorry . You can merge this pull request into a Git repository by running: $ git pull https://github.com/chengcheng222e/

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Christian Grobmeier
On Thu, Jun 13, 2013 at 9:40 PM, Lukasz Lenart wrote: > 2013/6/13 Christian Grobmeier : >> for future reference, what did you do? > > Re-edited page on Confluence to trigger auto-export and then I have > launched my fancy script to update Draft docs and after buildbot > mailed me, I have finally p

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Lukasz Lenart
2013/6/13 Christian Grobmeier : > for future reference, what did you do? Re-edited page on Confluence to trigger auto-export and then I have launched my fancy script to update Draft docs and after buildbot mailed me, I have finally published the Struts website with CMS ;-) Regards -- Łukasz + 4

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Christian Grobmeier
for future reference, what did you do? On Thu, Jun 13, 2013 at 9:11 PM, Lukasz Lenart wrote: > OK, resolved! > > http://struts.apache.org/development/2.x/docs/cookieprovider-interceptor.html > > 2013/6/13 Lukasz Lenart : >> 2013/6/13 Maurizio Cucchiara : >>> OK, looks like the exported file was n

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Lukasz Lenart
OK, resolved! http://struts.apache.org/development/2.x/docs/cookieprovider-interceptor.html 2013/6/13 Lukasz Lenart : > 2013/6/13 Maurizio Cucchiara : >> OK, looks like the exported file was not up to date. Take a look at [1]. >> >> Anyway, no problem for the release, IIRC the assembly goal will

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Lukasz Lenart
2013/6/13 Maurizio Cucchiara : > OK, looks like the exported file was not up to date. Take a look at [1]. > > Anyway, no problem for the release, IIRC the assembly goal will export > the updated version of the docs, doesn't it? Something is wrong :\ https://cwiki.apache.org/WW/cookieprovider-inte

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Maurizio Cucchiara
OK, looks like the exported file was not up to date. Take a look at [1]. Anyway, no problem for the release, IIRC the assembly goal will export the updated version of the docs, doesn't it? [1] https://cwiki.apache.org/confluence/display/WW/CookieProvider+Interceptor Maurizio Cucchiara On 13 J

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Maurizio Cucchiara
Really annoying... looking at the CookieProviderInterceptor class I didn't see any problem (my guess was there was a character not escaped correctly). Maurizio Cucchiara On 13 June 2013 16:41, Christian Grobmeier wrote: > Just saw this: > http://struts.apache.org/release/2.3.x/docs/cookieprovi

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Christian Grobmeier
Just saw this: http://struts.apache.org/release/2.3.x/docs/cookieprovider-interceptor.html Any ideas how to fix this? On Thu, Jun 13, 2013 at 1:55 PM, Christian Grobmeier wrote: > +1 from me also > > On Thu, Jun 13, 2013 at 7:03 AM, Lukasz Lenart > wrote: >> Hi, >> >> All the issues assigned t

Re: I18ninterceptor support for cookies

2013-06-13 Thread Lukasz Lenart
2013/6/13 Christian Grobmeier : > On Thu, Jun 13, 2013 at 2:48 PM, Lukasz Lenart > wrote: >> 2013/6/13 Christian Grobmeier : >>> Any ideas how to solve it? >>> >>> Otherwise i would create an issue for Struts 3, when the xwork package >>> most likely will disappear or when breaking changes are al

Re: I18ninterceptor support for cookies

2013-06-13 Thread Christian Grobmeier
On Thu, Jun 13, 2013 at 2:48 PM, Lukasz Lenart wrote: > 2013/6/13 Christian Grobmeier : >> Any ideas how to solve it? >> >> Otherwise i would create an issue for Struts 3, when the xwork package >> most likely will disappear or when breaking changes are allowed. > > The current idea is to keep XWo

Re: I18ninterceptor support for cookies

2013-06-13 Thread Lukasz Lenart
2013/6/13 Christian Grobmeier : > Hi, > > today i started to look into the I18nInterceptor because I wanted > to add the feature to store the Locale in a cookie, besides request-only > and session. > > I could do it like that: > > ActionContext ac = invocation.getInvocationContext(); > HttpServletR

Re: svn commit: r1492633 - /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/I18nInterceptor.java

2013-06-13 Thread Christian Grobmeier
On Thu, Jun 13, 2013 at 2:27 PM, Lukasz Lenart wrote: > It is better to make methods protected - easier to extend or restore > the old behaviour might make sense. For example: readStoredLocale might be able to read from cookies first, when overriding. This might also solve my previously mentioned

Re: svn commit: r1492633 - /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/I18nInterceptor.java

2013-06-13 Thread Lukasz Lenart
It is better to make methods protected - easier to extend or restore the old behaviour Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2013/6/13 : > Author: grobmeier > Date: Thu Jun 13 11:57:16 2013 > New Revision: 1492633 > > URL: http://svn.apache.org/r1492633 > Log: > some ref

I18ninterceptor support for cookies

2013-06-13 Thread Christian Grobmeier
Hi, today i started to look into the I18nInterceptor because I wanted to add the feature to store the Locale in a cookie, besides request-only and session. I could do it like that: ActionContext ac = invocation.getInvocationContext(); HttpServletResponse response = (HttpServletResponse) ac.get(S

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Christian Grobmeier
+1 from me also On Thu, Jun 13, 2013 at 7:03 AM, Lukasz Lenart wrote: > Hi, > > All the issues assigned to 2.3.15 are already solved, is there > anything urgent right now to be solved as well? If no, I will start > release process ASAP. > > https://issues.apache.org/jira/browse/WW/fixforversion/1

Re: Struts 2.3.15 is almost here

2013-06-13 Thread Rene Gielen
Looks good to me! Am 13.06.13 07:03, schrieb Lukasz Lenart: > Hi, > > All the issues assigned to 2.3.15 are already solved, is there > anything urgent right now to be solved as well? If no, I will start > release process ASAP. > > https://issues.apache.org/jira/browse/WW/fixforversion/12324267#s