Jenkins build became unstable: Struts-JDK6-develop #3

2014-02-18 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Jenkins build became unstable: Struts-JDK6-develop » Struts 2 Core #3

2014-02-18 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Lukasz Lenart
2014-02-19 7:23 GMT+01:00 Paul Benedict : > Wouldn't it make more sense for github requests to be sent to the commits > list than dev? Hmm good point. I will ask Infra if it is possible to send PR to commit@ and discuss via dev@ Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Paul Benedict
Wouldn't it make more sense for github requests to be sent to the commits list than dev? On Wed, Feb 19, 2014 at 12:20 AM, Lukasz Lenart wrote: > The final test > > 2014-02-18 16:09 GMT+01:00 Humbedooh : > > Github user Humbedooh commented on the pull request: > > > > https://github.com/apac

[GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread lukaszlenart
Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If your project does not have this feature ena

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Lukasz Lenart
The final test 2014-02-18 16:09 GMT+01:00 Humbedooh : > Github user Humbedooh commented on the pull request: > > https://github.com/apache/struts/pull/1#issuecomment-35393131 > > Testing GitHub integration, please ignore :) > > > --- > If your project is set up for it, you can reply to thi

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Lukasz Lenart
Please ignore, testing 2014-02-18 16:09 GMT+01:00 Humbedooh : > Github user Humbedooh commented on the pull request: > > https://github.com/apache/struts/pull/1#issuecomment-35393131 > > Testing GitHub integration, please ignore :) > > > --- > If your project is set up for it, you can repl

Re: [struts-dev] Code review

2014-02-18 Thread Lukasz Lenart
2014-02-18 16:24 GMT+01:00 Jason Pyeron : > Is the intention to have replies to the github messages on this list be added > to > the pull request comments? Yes, both ways. - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Lukasz Lenart
And again, and again... 2014-02-18 16:09 GMT+01:00 Humbedooh : > Github user Humbedooh commented on the pull request: > > https://github.com/apache/struts/pull/1#issuecomment-35393131 > > Testing GitHub integration, please ignore :) > > > --- > If your project is set up for it, you can rep

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Lukasz Lenart
And agina 2014-02-18 16:27 GMT+01:00 Lukasz Lenart : > Test again > > 2014-02-18 16:09 GMT+01:00 Humbedooh : >> Github user Humbedooh commented on the pull request: >> >> https://github.com/apache/struts/pull/1#issuecomment-35393131 >> >> Testing GitHub integration, please ignore :) >> >>

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Lukasz Lenart
Test again 2014-02-18 16:09 GMT+01:00 Humbedooh : > Github user Humbedooh commented on the pull request: > > https://github.com/apache/struts/pull/1#issuecomment-35393131 > > Testing GitHub integration, please ignore :) > > > --- > If your project is set up for it, you can reply to this em

RE: [struts-dev] Code review

2014-02-18 Thread Jason Pyeron
> -Original Message- > From: Lukasz Lenart > Sent: Tuesday, February 18, 2014 9:10 > > Hi, > > I have created PR via GitHub so everybody can simple review > the changes. It's far easier to use GH for that than use > Review Board or Fisheye. For now I think it is preferred way > if you

Re: [GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Lukasz Lenart
Testing integration 2014-02-18 16:09 GMT+01:00 Humbedooh : > Github user Humbedooh commented on the pull request: > > https://github.com/apache/struts/pull/1#issuecomment-35393131 > > Testing GitHub integration, please ignore :) > > > --- > If your project is set up for it, you can reply t

[GitHub] struts pull request: Don't pass ServletContext

2014-02-18 Thread Humbedooh
Github user Humbedooh commented on the pull request: https://github.com/apache/struts/pull/1#issuecomment-35393131 Testing GitHub integration, please ignore :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, ple

Code review

2014-02-18 Thread Lukasz Lenart
Hi, I have created PR via GitHub so everybody can simple review the changes. It's far easier to use GH for that than use Review Board or Fisheye. For now I think it is preferred way if you want to get others' opinion about your changes. https://github.com/apache/struts/pull/1 Regards -- Łukasz