[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-04 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45182314 > BTW what is table.ftl and where it is used? First I thought it's used by `debug.ftl` but I've checked that and it's not - so it's some leftover, also there

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-04 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45182042 It can stay as is for now IMO, we can think about that with S2.5 or S3 - remove hardcoded styles and used CSS classes instead. Then `simple` theme won't provide any s

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-04 Thread aleksandr-m
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45139719 In most cases it doesn't really matter, but yes it isn't a perfect solution. Do you think adding classes to elements and including a CSS file to `simple` theme is bett

[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...

2014-06-04 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45061200 I'm not sure if this is the best idea, I mean hardcoding styles in tags - they will always take precedence over CSS classes. --- If your project is set up for it, yo