Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Lukasz Lenart
2015-05-22 8:28 GMT+02:00 Johannes Geppert : > That's great Umesh! > > @Lukasz > Is maybe a ICLA required for that? Good question but I assumed no if this will be contributed via patch/GitHub PR - it's the same as others do > After import I would suggest to rename it to bean-validation-plugin. >

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Johannes Geppert
That's great Umesh! @Lukasz Is maybe a ICLA required for that? After import I would suggest to rename it to bean-validation-plugin. I think having a specific JSR number in the name is confusing people they don't know it. And if we later some other JSR's are following for bean validation it is not

[GitHub] struts-site pull request: WW-4502 - File listing for dtd-s

2015-05-21 Thread aleksandr-m
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts-site/pull/2 WW-4502 - File listing for dtd-s You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts-site WW-4502 Alternatively you can r

Build failed in Jenkins: Struts-JDK7-pull-request #26

2015-05-21 Thread Apache Jenkins Server
See Changes: [Lukasz Lenart] Defines new interface to implement specialized internal converters [Lukasz Lenart] Adds new internal converter of Double to String [Lukasz Lenart] Uses the new internal converters and adds new test

Build failed in Jenkins: Struts-JDK6-develop #158

2015-05-21 Thread Apache Jenkins Server
See -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu ubuntu legacy-ubuntu) in workspace Cloning the remote Git repository Clonin

[GitHub] struts pull request: Locale aware converters

2015-05-21 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/37 Locale aware converters WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts locale-aware-converters Alternatively you ca

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Lukasz Lenart
2015-05-21 18:24 GMT+02:00 Umesh Awasthi : > I am more than happy to donate the plugin. Please let me know what need to > be done from my end for this. Great! There are two options: - prepare a patch and attach it to a JIRA ticket - prepare a PR on GitHub and register task in the JIRA in both opt

[GitHub] struts pull request: WW-4355 - Replace deprecated HTML attributes ...

2015-05-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-104374079 Please re-open this PR against `master` branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-05-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-104374138 Please re-open this PR against `master` branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] struts pull request: Added support for new Java 8 LocalDate and Lo...

2015-05-21 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/31#issuecomment-104373960 Please re-open this PR against `master` branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] struts pull request: Use js to support multiple buttons

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] struts pull request: Http interceptor

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] struts pull request: WW-4355 - Replace deprecated HTML attributes ...

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] struts pull request: Added support for new Java 8 LocalDate and Lo...

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] struts pull request: Locale aware converters

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Starting work on 2.5

2015-05-21 Thread Lukasz Lenart
Starting with the master plan - please do not touch Git :) 2015-05-17 10:33 GMT+02:00 Lukasz Lenart : > 2015-05-15 15:08 GMT+02:00 Lukasz Lenart : >> Finally struts-archive was migrated to Git [1] so I can kicking out >> deprecated plugins and start cleaning up the code [2] >> >> [1] https://git1-

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Umesh Awasthi
I am more than happy to donate the plugin. Please let me know what need to be done from my end for this. Thanks Umesh On Thu, May 21, 2015 at 12:37 AM, Lukasz Lenart wrote: > 2015-05-21 9:17 GMT+02:00 Christoph Nenning >: > > Yeah, would be great to support more JSRs. > > I would even go furth

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Lukasz Lenart
2015-05-21 9:17 GMT+02:00 Christoph Nenning : > Yeah, would be great to support more JSRs. > I would even go further and deprecate struts validation. > > Well, ok I guess struts validation is more powerfull and will stay. Just > want to emphasize that I prefer to rely on existing specs. I would li

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Christoph Nenning
> Hi all, > > I just played a little bit with the bean validation plugin created by Umesh > Awasthi. > > https://github.com/struts-community-plugins/jsr303-validator-plugin > > My first tests are successfully and it works fine for me. > > What you all think about an import to our main distribu