Re: Upgrading Tiles plugin

2015-11-27 Thread Lukasz Lenart
Now I have started thinking about upgrading/redoing the Tiles 3 plugin and the problem is with conflicting dependencies. Also, it looks like Tiles 3 can handle Tiles 2 definitions, so I'm wondering if it makes sense to drop the Tiles plugin and replace it with the Tiles 3 plugin. My work on

[GitHub] struts pull request: Upgrade tiles plugin

2015-11-27 Thread aleksandr-m
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160195199 Tested with own app and it is running fine. Looking forward to see the same approach with `StrutsTilesContainerFactory` in tiles3 plugin. BTW what is

Re: [GitHub] struts pull request: Upgrade tiles plugin

2015-11-27 Thread JOSE L MARTINEZ-AVIAL
Is there a snapshot that can be used to test it? 2015-11-27 10:18 GMT-05:00 cnenning : > Github user cnenning commented on the pull request: > > https://github.com/apache/struts/pull/59#issuecomment-160158437 > > yay, it runs ! :smiley: > > > --- > If your project is

[GitHub] struts pull request: Upgrade tiles plugin

2015-11-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160149229 I have the same issue, no idea what's wrong but will try to figure it out. Regarding Tiles 3, it looks very similar to Tiles 2 and I'm going to work on them with

[GitHub] struts pull request: Upgrade tiles plugin

2015-11-27 Thread cnenning
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160149460 I hope that code can be shared between both tiles plugins. What do you think of creating a strust-tiles-commons.jar or somthing the like? --- If your project is set up

[GitHub] struts pull request: Upgrade tiles plugin

2015-11-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160149850 Will see :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] struts pull request: Upgrade tiles plugin

2015-11-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160157282 @cnenning issue with `javax.el` resolved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] struts pull request: Upgrade tiles plugin

2015-11-27 Thread cnenning
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160158437 yay, it runs ! :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have