Re: [VOTE] Struts 2.5

2016-05-06 Thread Johannes Geppert
> [ ] Leave at test build > [ ] Alpha > [ ] Beta > [X] General Availability (GA) +1 (binding) Best Regards Johannes Am 05.05.2016 21:23 schrieb "Lukasz Lenart" : > The Apache Struts 2.5 test build is now available. With this release: > > - All security fixes were ported from previous versions >

Re: [VOTE] Struts 2.5

2016-05-06 Thread Lukasz Lenart
2016-05-05 21:23 GMT+02:00 Lukasz Lenart : > [ ] Leave at test build > [ ] Alpha > [ ] Beta > [X] General Availability (GA) +1 (binding) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: de

Re: [VOTE] Struts 2.5

2016-05-06 Thread victor sosa
Sorry my mistake ; I confused that issue with this one WW-4558. On 05/06/2016 06:12 PM, victor sosa wrote: > Hi, > > "Rest plugin honors Accept header, see WW-4588" > > This PR still open and it hasn't been pulled yet. Please check. > > > On 05/05/2016 03:23 PM, Lukasz Lenart wrote: >> The Apache

Re: [VOTE] Struts 2.5

2016-05-06 Thread victor sosa
OK [ ] Leave at test build [ ] Alpha [ ] Beta [x] General Availability (GA) On 05/05/2016 03:23 PM, Lukasz Lenart wrote: > The Apache Struts 2.5 test build is now available. With this release: > > - All security fixes were ported from previous versions > - XWork source was merged into Struts Core

Re: [VOTE] Struts 2.5

2016-05-06 Thread victor sosa
Hi, "Rest plugin honors Accept header, see WW-4588" This PR still open and it hasn't been pulled yet. Please check. On 05/05/2016 03:23 PM, Lukasz Lenart wrote: > The Apache Struts 2.5 test build is now available. With this release: > > - All security fixes were ported from previous versions >

Re: Re: Struts 2.5

2016-05-06 Thread Aleksandr Mashchenko
A lot of parenthesis :) Great, thanks! --- Regards, Aleksandr - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Re: Re: Struts 2.5

2016-05-06 Thread Lukasz Lenart
2016-05-06 11:58 GMT+02:00 Lukasz Lenart : > 2016-05-06 11:55 GMT+02:00 Aleksandr Mashchenko : 2016-05-06 10:19 GMT+02:00 Aleksandr Mashchenko : Some strange issue here with 2.5. Required labels are shown on both sides of the label. Seems like both if-s in xhtml control

Re: Re: Struts 2.5

2016-05-06 Thread Lukasz Lenart
2016-05-06 11:55 GMT+02:00 Aleksandr Mashchenko : >>>2016-05-06 10:19 GMT+02:00 Aleksandr Mashchenko : >>> Some strange issue here with 2.5. >>> >>> Required labels are shown on both sides of the label. Seems like both >>> if-s >>> in xhtml controlheader-core.ftl evaluate to true. >>> >>> >>> https

Re: Re: Struts 2.5

2016-05-06 Thread Aleksandr Mashchenko
>>2016-05-06 10:19 GMT+02:00 Aleksandr Mashchenko : >> Some strange issue here with 2.5. >> >> Required labels are shown on both sides of the label. Seems like both if-s >> in xhtml controlheader-core.ftl evaluate to true. >> >> https://github.com/apache/struts/blob/master/core/src/main/resourc

Re: [VOTE] Struts 2.5

2016-05-06 Thread Greg Huber
Its good for me. Great work, thanks. [ ] Leave at test build [ ] Alpha [ ] Beta [x] General Availability (GA) On 5 May 2016 at 20:23, Lukasz Lenart wrote: > The Apache Struts 2.5 test build is now available. With this release: > > - All security fixes were ported from previous versions > - XW

Re: [VOTE] Struts 2.5

2016-05-06 Thread Lukasz Lenart
2016-05-06 10:31 GMT+02:00 Aleksandr Mashchenko : >> Has the s:div tag been removed? > > Yes, is was left over from ajax theme. There were two versions, static and ajax aware - but as far I see the static version is just simply a so the migration is easy. Regards -- Łukasz + 48 606 323 122 htt

Re: [VOTE] Struts 2.5

2016-05-06 Thread Lukasz Lenart
Removed with this issue https://issues.apache.org/jira/browse/WW-4614 but we need Aleksandr to clarify why. 2016-05-06 10:28 GMT+02:00 Lukasz Lenart : > Ups... my bad, there were two versions of it need to check that > > 2016-05-06 10:26 GMT+02:00 Lukasz Lenart : >> 2016-05-06 10:24 GMT+02:00

[VOTE] Struts 2.5

2016-05-06 Thread Aleksandr Mashchenko
> Has the s:div tag been removed? Yes, is was left over from ajax theme. --- Regards, Aleksandr - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Struts 2.5

2016-05-06 Thread Lukasz Lenart
Ups... my bad, there were two versions of it need to check that 2016-05-06 10:26 GMT+02:00 Lukasz Lenart : > 2016-05-06 10:24 GMT+02:00 Greg Huber : >> Has the s:div tag been removed? >> >> I now get : >> >> No tag "div" defined in tag library imported with prefix "s" > > I think it was a Str

Re: [VOTE] Struts 2.5

2016-05-06 Thread Lukasz Lenart
2016-05-06 10:24 GMT+02:00 Greg Huber : > Has the s:div tag been removed? > > I now get : > > No tag "div" defined in tag library imported with prefix "s" I think it was a Struts 2 Dojo plugin tag, not a Struts 2 Core tag. The plugin was deprecated for long time and was finally dropped in Struts 2

Re: Struts 2.5

2016-05-06 Thread Lukasz Lenart
2016-05-06 10:19 GMT+02:00 Aleksandr Mashchenko : > Some strange issue here with 2.5. > > Required labels are shown on both sides of the label. Seems like both if-s > in xhtml controlheader-core.ftl evaluate to true. > > https://github.com/apache/struts/blob/master/core/src/main/resources/template/

Re: [VOTE] Struts 2.5

2016-05-06 Thread Greg Huber
Has the s:div tag been removed? I now get : No tag "div" defined in tag library imported with prefix "s" On 5 May 2016 at 20:23, Lukasz Lenart wrote: > The Apache Struts 2.5 test build is now available. With this release: > > - All security fixes were ported from previous versions > - XWork s

Struts 2.5

2016-05-06 Thread Aleksandr Mashchenko
Some strange issue here with 2.5. Required labels are shown on both sides of the label. Seems like both if-s in xhtml controlheader-core.ftl evaluate to true. https://github.com/apache/struts/blob/master/core/src/main/resources/template/xhtml/controlheader-core.ftl#L65 and https://github.com/a

Re: Release Struts 2.5

2016-05-06 Thread Lukasz Lenart
No, Strict DMI was introduced some time ago (in 2.3.x) and SMI is a bit different, more restrictive. Maybe it would be a good idea to drop Strict DMI section at some point. 2016-05-06 10:06 GMT+02:00 Greg Huber : > Should the Strict DMI section have a 2.5 dtd? > > "-//Apache Software Foundati

Re: Release Struts 2.5

2016-05-06 Thread Greg Huber
Should the Strict DMI section have a 2.5 dtd? http://struts.apache.org/dtds/struts-2.3.dtd"; > it uses strict-method-invocation="true". On 5 May 2016 at 07:45, Lukasz Lenart wrote: > I updated docs to match the new logic > > > https://cwiki.apac