[GitHub] struts issue #120: WW-4753: Injectable context

2017-03-10 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/120 Thanks but that failing test is 50% of work ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] struts issue #120: WW-4753: Injectable context

2017-03-10 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/120 Besides the failing test this looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

Build failed in Jenkins: Struts-JDK7-pull-request #234

2017-03-10 Thread Apache Jenkins Server
See Changes: [Lukasz Lenart] Makes factory fully injectable [Lukasz Lenart] Uses the new injectable factory to obtain TextProvider [Lukasz Lenart] Adjust usage of the factory [Lukasz Lenart] Drops empty

[GitHub] struts pull request #120: WW-4753: Injectable context

2017-03-10 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/120 WW-4753: Injectable context This PR converts statically created validation contexts into injectable beans. It's intermediate step to convert `LocalizedTextUtil` into a bean. You can merge this