Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 20:23 GMT+01:00 Aaron Johnson : > Keeping breaking changes in major releases is important. I recently took a > project from 2.5.8 to 2.5.10.1 and had several compilation errors. Not a > good surprise when attempting to get a security fix in quickly. That would be awesome but it's hard i

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

I agree with respecting major/minor versions concerning breaking changes. I also encountered an unexpected problem with updating one of our projects at work to 2.5.10.1 (from 2.5.1), which didn’t even cause a compilation error. In my case it was because of the introduction of a parameter object.

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

Keeping breaking changes in major releases is important. I recently took a project from 2.5.8 to 2.5.10.1 and had several compilation errors. Not a good surprise when attempting to get a security fix in quickly. On Thu, Mar 16, 2017 at 8:35 AM, Lukasz Lenart wrote: > 2017-03-16 13:21 GMT+01:00 C

Build failed in Jenkins: Struts-JDK9-master #86

See Changes: [amashchenko] use commons-lang3 classes, use StringUtils removeEnd instead of [amashchenko] WW-4748 Upgrade commons-lang3 to 3.5 [amashchenko] WW-4761 Improve error logging in DefaultDispatcherErro

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 13:21 GMT+01:00 Christoph Nenning : > I'd say it is too big for a minor version update -> let's put it in 2.6 https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%202.6%20AND%20project%20%3D%20WW%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC Regards -- Ł

Re: S2 makes Hacker News :/

From: Greg Huber Sent: Thursday, March 16, 2017 5:19 AM To: Struts Developers List Subject: Re: S2 makes Hacker News :/ Just because you are using s2, does not necessarily mean you are affected, all I get is a response : HTTP/1.1 404 Content-Length: 0 Date: T

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

> > I like those ideas! > > > > Currently it is a bit messy to figure out what can be customized or used > > by apps and what are struts internals. Having an explicit API would clear > > things up. > > Yeah, it should be a bit easier. The question is: do it now or wait > till Struts 2.6? > I'

Build failed in Jenkins: Struts-JDK9-master #85

See Changes: [Lukasz Lenart] Defines new interface for factory [Lukasz Lenart] Adds default implementation of the factory [Lukasz Lenart] Replaces LocaleProvider with LocaleProviderFactory [Lukasz Lenart] Inje

Re: S2 makes Hacker News :/

Just because you are using s2, does not necessarily mean you are affected, all I get is a response : HTTP/1.1 404 Content-Length: 0 Date: Thu, 16 Mar 2017 09:02:54 GMT Connection: close Looking at my logs this fishing is going on all the time. Thanks also Lukasz for the quick fix. Cheers Greg

[GitHub] struts pull request #122: WW-4757: LocaleProvider factory

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 10:52 GMT+01:00 Christoph Nenning : > I like those ideas! > > Currently it is a bit messy to figure out what can be customized or used > by apps and what are struts internals. Having an explicit API would clear > things up. Yeah, it should be a bit easier. The question is: do it now or

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

I like those ideas! Currently it is a bit messy to figure out what can be customized or used by apps and what are struts internals. Having an explicit API would clear things up. Regards, Christoph > From: Lukasz Lenart > To: Struts Developers List , > Date: 15.03.2017 09:29 > Subject: Inje

Re: LocaleProviderFactory

2017-03-16 10:26 GMT+01:00 Greg Huber : > Would that be in the comment? Comment or you can mark the PR's description (on the right there is "Add your reaction" smiley face ) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ ---

Re: LocaleProviderFactory

Would that be in the comment? On 16 March 2017 at 09:23, Lukasz Lenart wrote: > 2017-03-16 10:21 GMT+01:00 Greg Huber : > > +1, works for me. > > Cool, thanks :) Can you mark the PR with :+1: as well? > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > --

Re: LocaleProviderFactory

2017-03-16 10:21 GMT+01:00 Greg Huber : > +1, works for me. Cool, thanks :) Can you mark the PR with :+1: as well? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: [email protected]

Re: LocaleProviderFactory

+1, works for me. Cheers Greg On 15 March 2017 at 17:54, Lukasz Lenart wrote: > If no objections I will merge this PR [1] tomorrow > > [1] https://github.com/apache/struts/pull/122 > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > -

Re: LocaleProviderFactory

2017-03-15 20:01 GMT+01:00 Stefaan Dutry : > I have a question about the pull request. > > In the interface LocaleProviderFactory, there's only a method called > createLocaleProvider. > > Does this mean that there's supposed to be a seperate instance of > LocaleProvider on every single place this i