[GitHub] struts issue #157: WW-4834 fixed faulty regex

2017-08-03 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/157 I would wait a bit and give Adam a chance to post a comment (if he wants to). No rush :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] struts issue #157: WW-4834 fixed faulty regex

2017-08-03 Thread sdutry
Github user sdutry commented on the issue: https://github.com/apache/struts/pull/157 @lukaszlenart Sorry for breaking it in the first place. That wasn't my intention. Do you want me to merge this now, or am i still overlooking stuff? --- If your project is set up for it,

[GitHub] struts issue #157: WW-4834 fixed faulty regex

2017-08-03 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/157 I think we are good here, thanks a lot for yours work :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] struts issue #157: WW-4834 fixed faulty regex

2017-08-03 Thread sdutry
Github user sdutry commented on the issue: https://github.com/apache/struts/pull/157 > After the commit above, any IP with 3 digits in the last octet will not pass validation You are right, i forgot the grouping (meaning the or statements mean something completely different),

[GitHub] struts issue #157: WW-4834 fixed faulty regex

2017-08-03 Thread atcazzual
Github user atcazzual commented on the issue: https://github.com/apache/struts/pull/157 The expression did not seem to work at all until I escaped the slashes, changing `/` to `\/` Once I got it working, there then seems to be a bug in the new expression when matching on U

Struts 2.5.13

2017-08-03 Thread Lukasz Lenart
Hi We are almost good to go ... there is one issue to be reviewed and I can start the release process. https://issues.apache.org/jira/projects/WW/versions/12341116 Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ -

[GitHub] struts pull request #158: WW-4835: Configurable handlers

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] struts issue #158: WW-4835: Configurable handlers

2017-08-03 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/158 sounds great 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] struts issue #158: WW-4835: Configurable handlers

2017-08-03 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/158 With the `ActionInvocation` in place I can access an action which means the action can provide additional informations how to serialise/deserialize object/string via dedicated interfaces, e.g.

[GitHub] struts issue #158: WW-4835: Configurable handlers

2017-08-03 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/158 and what is your idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] struts issue #158: WW-4835: Configurable handlers

2017-08-03 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/158 Merge it first as I think those changes are less intrusive as the whole idea in my head ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] struts issue #158: WW-4835: Configurable handlers

2017-08-03 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/158 Do you want to further develop this PR or merge it first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] struts pull request #155: WW-4827: post init

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] struts pull request #153: WW-4827 Not fully initialized ObjectFactory tries ...

2017-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab