Re: Renaming "parameters" to "attributes" in tags

2024-10-07 Thread Greg Huber
Works ok.  I tried it from branch feature/WW-5465-attributes. On 06/10/2024 17:57, Lukasz Lenart wrote: Here is the PR addressing this proposal https://github.com/apache/struts/pull/1067 niedz., 6 paź 2024 o 07:40 Lukasz Lenart napisał(a): Hi, During investigation of issue WW-5452 [1] I disc

Re: Renaming "parameters" to "attributes" in tags

2024-10-07 Thread Lukasz Lenart
pon., 7 paź 2024 o 15:42 Burton Rhodes napisał(a): > > I would argue for changing the name to "attributes" since v7 introduces > breaking changes already, and this will avoid confusion moving forward. > Your PR seems to work fine in my test environment (provided I changed > some of my overridden .

Re: Renaming "parameters" to "attributes" in tags

2024-10-07 Thread Burton Rhodes
I would argue for changing the name to "attributes" since v7 introduces breaking changes already, and this will avoid confusion moving forward. Your PR seems to work fine in my test environment (provided I changed some of my overridden .ftl files). Just FYI, building the latest snapshot (PR 1