Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/124
Great work, LGTM! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/124
Cool, I will review this tomorrow just to double check and LGTM! Great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
@lukaszlenart , Yes in my opinion, Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/124
So as I understand this is ready to be merged with a future notice to use
Commons Lang 3.6 when available?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
â
All copied Spring's code including what I was imported in previously
merged [PR#117](https://github.com/apache/struts/pull/117) removed ð
After merge of [LANG-1317
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
> Do we need custom annotation utility at all? Can't we just use existing
libraries e.g. Apache Commons MethodUtils?
Thank you @aleksandr-m !
I am working on it. I started by
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
I also wait for ASF LEGAL part's answer but after some study, it seems I
was not allowed to do such work ð If so, I think I have to write my own
utils at where @aleksandr-m mentioned;
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
> We must rather ask ASF legal body, you can post an issue in JIRA (see
above)
Thank you. As I could not find similar issue, I created [Merge others codes
having same license but
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/124
We must rather ask ASF legal body, you can post an issue in JIRA (see above)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/124
> Yasser explain why he did that
Thank you for your review.
`AnnotationUtils` is not a new class but to avoid reinventing the wheel, I
copied and merged some codes from Spring
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/124
Do we need custom annotation utility at all? Can't we just use existing
libraries e.g. Apache Commons
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/124
> That's the class that has been copied from spring
I meant, coping classes is ok if the license allows that (Spring uses AL
2.0) but my questions was about adding authors to some other
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/124
> Should I ask legal [1] about that? What do you think?
That's the class that has been copied from spring. Yes, I think it's better
to ask how to handle this.
---
If your project is set
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/124
Looks good, just have some doubts about putting `@author` tag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
14 matches
Mail list logo
