[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-06-27 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-47332091 The work continue in #18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-06-26 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-47312080 :eyes: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-05-22 Thread abrin
Github user abrin commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-43969902 Hi Lukasz, On my branch I wasn’t able to get it to pass the tests, were you able to? thanks, adam On May 20, 2014, at 11:09 PM, Lukasz Le

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-05-20 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-43715553 I think this is ready? Anything else to add? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-24 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10886552 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.findValue(

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-24 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10886002 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-24 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-38449857 Ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10784708 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-20 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10784514 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10779343 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.findValue(

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10777092 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.findValue(

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10771988 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10771172 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10770140 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10770402 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.findValue(

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10769526 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10768356 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10753958 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.findValue(

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10740666 --- Diff: core/src/main/resources/template/simple/radiomap.ftl --- @@ -27,7 +27,13 @@ <#assign itemKey = stack.findValue('top')/>

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10740655 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.fin

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread lukaszlenart
Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10740672 --- Diff: core/src/main/resources/template/simple/select.ftl --- @@ -69,7 +69,13 @@ <#assign itemKey = stack.findValue('top')/>

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-18 Thread abrin
GitHub user abrin opened a pull request: https://github.com/apache/struts/pull/7 [PATCH] First attempt at enabling value-labels to be pulled from Locale Files. Adding listValueKey attribute to checkboxList, radioMap, and select tags. Issues: This implementation us