Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-53678964
https://issues.apache.org/jira/browse/WW-4355 :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-53678677
Did you create appropriated JIRA ticket?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-47358634
I'm going to postpone this PR, it will break Dojo plugin, we can include
the changes in S2.5 when Dojo plugin will be dropped as well.
---
If your project is set up
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-47334012
Is this ready for another shot?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-45186957
OK. Pushed that changes for future use. There are some places where align
is used directly because of `align` attribute in tags.
---
If your project is set up for it,
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-45182314
> BTW what is table.ftl and where it is used?
First I thought it's used by `debug.ftl` but I've checked that and it's not
- so it's some leftover, also there
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-45182042
It can stay as is for now IMO, we can think about that with S2.5 or S3 -
remove hardcoded styles and used CSS classes instead. Then `simple` theme won't
provide any s
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-45139719
In most cases it doesn't really matter, but yes it isn't a perfect
solution. Do you think adding classes to elements and including a CSS file to
`simple` theme is bett
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-45061200
I'm not sure if this is the best idea, I mean hardcoding styles in tags -
they will always take precedence over CSS classes.
---
If your project is set up for it, yo
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/14
WW-4355 - Remove HTML5 deprecated attributes from templates
Changed HTML5 deprecated attributes to CSS in templates.
You can merge this pull request into a Git repository by running:
$ git p
10 matches
Mail list logo
