Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-172460318
> Simplifies logging
Still not final :wink: ?
Let's merge it!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-172462730
I have got some comments on my questions sent to Tiles Users mailing list
and the current implementation isn't optimal ;-) But I have no better idea so
let's merge
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171968504
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171909190
I think the solution is final, I have added support for Struts' Locale and
properly implemented support for it. I also updated `struts-examples`. Enjoy!
---
If
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171590254
:+1:
It works.
Thank you for your great work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171891083
> In my experiments the tiles.xml was only loaded one time, at first
request.
Yes, it was clarified during my discussion on Tiles Users mailing list
---
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171662399
> I have resolved the problem with missing definitions but I'm a bit
confused how Tiles resolves
> resources - 66d29d4 - basically all the definitions are loaded on
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171256054
I have resolved the problem with missing definitions but I'm a bit confused
how Tiles resolves resources - 66d29d4 - basically all the definitions are
loaded on
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/73
WW-4584: Upgrade tiles plugin
[WW-4584](https://issues.apache.org/jira/browse/WW-4584) Upgrades Tiles
plugin to use Tiles 3 version, it also drops Tiles 3 plugin - there will be
only one
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171035814
Same thing here. Getting `NoSuchDefinitionException` exception in my app
when trying to use tiles result.
Note: there is still reference to tiles3-plugin in
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171055589
Thanks, I found the reason, now working on solution
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-170932000
:+1:
Looks great!
There is one thing: when I try to run showcase app I get exceptions when
trying to access tiles examples:
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-170938090
I just ported the solution from `support-2-3` branch and adjusted API,
didn't test it yet but will do it later today, tomorrow. I hope it's be an easy
fix ;-)
---
14 matches
Mail list logo
