Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/85#issuecomment-179082503
Great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user cnenning commented on the pull request:
https://github.com/apache/struts/pull/85#issuecomment-179082240
Alright, thanks for reviewing. I agree with your findings and pushed
updates.
I'm going to merge it later.
---
If your project is set up for it, you can reply
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/85#issuecomment-176859924
Left some minor comment, this looks solid, great job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51285182
--- Diff:
plugins/tiles/src/test/java/org/apache/struts2/tiles/TilesTestActionSingleAnnotation.java
---
@@ -0,0 +1,49 @@
+package org.apache.struts2.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51285068
--- Diff:
plugins/tiles/src/test/java/org/apache/struts2/tiles/StrutsTilesAnnotationProcessorTest.java
---
@@ -0,0 +1,148 @@
+package org.apache.stru
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51284943
--- Diff:
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -99,6 +109,18 @@ public TilesResult(String location) {
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51285002
--- Diff:
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -111,6 +133,31 @@ public void doExecute(String location,
Act
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51284785
--- Diff:
apps/showcase/src/main/java/org/apache/struts2/showcase/tiles/TilesAnnotationsAction.java
---
@@ -0,0 +1,21 @@
+package org.apache.struts2.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51284673
--- Diff:
apps/showcase/src/main/java/org/apache/struts2/showcase/tiles/TilesAnnotationsAction.java
---
@@ -0,0 +1,21 @@
+package org.apache.struts2.
Github user cnenning commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r50693282
--- Diff:
plugins/tiles/src/test/java/org/apache/struts2/tiles/TestStrutsTilesAnnotationProcessor.java
---
@@ -0,0 +1,148 @@
+package org.apache.struts2.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r50692670
--- Diff:
plugins/tiles/src/test/java/org/apache/struts2/tiles/TestStrutsTilesAnnotationProcessor.java
---
@@ -0,0 +1,148 @@
+package org.apache.stru
GitHub user cnenning opened a pull request:
https://github.com/apache/struts/pull/85
WW-4594: Configure TilesDefs by annotating Actions
Adds annotations for each element from `tiles.xml` to annotate actions.
Those annotations are processed by a new class in tiles-plugin which is use
13 matches
Mail list logo
