Re: [S2] Struts 2.0.2 Build - ON HOLD

I attached WW-1554_2.patch (use this one instead of the previous ones) to WW-1554, a parameter was missing in notifyTopics. It has a fix to hangman ajax, which now works. There is an image attached to the ticket that needs to be added to showcase. regards musachy Musachy Barroso wrote: I'm t

Re: [S2] Struts 2.0.2 Build - ON HOLD

I'm trying to get hangman to work. musachy Ted Husted wrote: OK, we're getting closer, but there's still a few issues to resolve, if 2.0.2 is going to be a step forward. * Apply patch for Dojo topic notification (WW-1554) * Apply patch for DatePicker (WW-1555) * Fix XSLT Result (WW-1550) *

Re: [S2] Struts 2.0.2 Build - ON HOLD

OK, we're getting closer, but there's still a few issues to resolve, if 2.0.2 is going to be a step forward. * Apply patch for Dojo topic notification (WW-1554) * Apply patch for DatePicker (WW-1555) * Fix XSLT Result (WW-1550) * Move Continuations support to an experimental plugin (WW-1548)

Re: [S2] Struts 2.0.2 Build - ON HOLD

Yeah that one. The multiple(list) and multiple(array) are working, I hadn't tried'em before. The tests pass, that what the first thing I tried. I'll double-check to see if I figure it out. musachy Don Brown wrote: Nope, and I'm able to successfully upload a file on the single, multiple (array

Re: [S2] Struts 2.0.2 Build - ON HOLD

Another thing - if this was truly a bug, then our unit tests should be failing. Take a look at the file upload unit test and see if it is properly testing the feature. Don Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize)

Re: [S2] Struts 2.0.2 Build - ON HOLD

Nope, and I'm able to successfully upload a file on the single, multiple (array), and multiple (list). To be clear, this page has the file upload tests that are failing? http://localhost:8080/struts2-showcase/fileupload/ Don Musachy Barroso wrote: Yeap, I always get "File cannot be empty" (v

Re: [S2] Struts 2.0.2 Build - ON HOLD

Yeap, I always get "File cannot be empty" (validation upload.lenght() > 0 failing) message. Do you have any uncommitted changes? musachy Don Brown wrote: Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is ava

Re: [S2] Struts 2.0.2 Build - ON HOLD

Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a

Re: [S2] Struts 2.0.2 Build - ON HOLD

setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a problem in 1.1.1. musachy Musachy Barroso wrote: The problem with the fileupload examples is that Don added t

Re: [S2] Struts 2.0.2 Build - ON HOLD

The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the va

Re: [S2] Struts 2.0.2 Build - ON HOLD

We should change the example to not use the "do" methods anymore. On 12/8/06, Musachy Barroso <[EMAIL PROTECTED]> wrote: The tokens examples are failing because the "doInput" is never being called in "TokenAction", instead "input" is being called on ActionSupport, that's why the values are not o

Re: [S2] Struts 2.0.2 Build - ON HOLD

The tokens examples are failing because the "doInput" is never being called in "TokenAction", instead "input" is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this "doX" method discovery work? I can't find it on the docs.

Re: [S2] Struts 2.0.2 Build - ON HOLD

We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix exampl

Re: [S2] Struts 2.0.2 Build - ON HOLD

Sorry for being a PITA :), but I have to log everything or I forget it. thanks musachy Rainer Hermanns wrote: Yep, I'll look into this later at home... Already seen your comment :) thanks, Rainer The submit tag has the same problem, I logged WW-1547 just to make sure we don't forget it. r

Re: [S2] Struts 2.0.2 Build - ON HOLD

Yep, I'll look into this later at home... Already seen your comment :) thanks, Rainer > The submit tag has the same problem, I logged WW-1547 just to make sure > we don't forget it. > > regards > musachy > > Musachy Barroso wrote: >> I did missed that one :) >> >> I'm not sure about the "ajaxHref"

Re: [S2] Struts 2.0.2 Build - ON HOLD

The submit tag has the same problem, I logged WW-1547 just to make sure we don't forget it. regards musachy Musachy Barroso wrote: I did missed that one :) I'm not sure about the "ajaxHref", because it means the same as "href", IMO it is going to be confusing. What if we don't build the ur

Re: [S2] Struts 2.0.2 Build - ON HOLD

I might not be able to tag it tonight, but tomorrow's looking good. In the meantime, there's are outstanding issues for Struts 2.0.3 and 2.0.x, generally, if anyone is interested. We just might want to hold off on the patches until Friday. * https://issues.apache.org/struts/secure/IssueNavigato

Re: [S2] Struts 2.0.2 Build - ON HOLD

I'm assuming this is still the issue holding us up. . .if there's anything else that needs to be done prior to the release, I've got some spare cycles for the next few days to help push it. Just let me know David Ted Husted wrote: I just filed * https://issues.apache.org/struts/browse/WW-15

Re: [S2] Struts 2.0.2 Build - ON HOLD

I did missed that one :) I'm not sure about the "ajaxHref", because it means the same as "href", IMO it is going to be confusing. What if we don't build the url at all, and just use it as it is ( addParameter("href"), findString(href)), and document that the url needs to be built with the "u

Re: [S2] Struts 2.0.2 Build - ON HOLD

GMail has been marking many JIRA posting as spam lately (no doubt because several are now). In case anyone missed it, Rainer posted a comment to the ticket. * http://issues.apache.org/struts/browse/WW-1537?page=all -Ted. On 12/4/06, Musachy Barroso <[EMAIL PROTECTED]> wrote: Well, I need help

Re: [S2] Struts 2.0.2 Build - ON HOLD

Well, I need help on this one: if (href != null) addParameter("href", UrlHelper.buildUrl(findString(href), request, response, null)); I can't figure out how to know if href ("%{url}") is pointing to a url that already contains the context. Checking if it starts with the context really smel

Re: [S2] Struts 2.0.2 Build - ON HOLD

The anchor demo on showcase will break, if it is holding the build we can just change the Anchor class, something like addParameter("href", null); addParameter("href", findString(href)); to make it behave like before, I will fix it after 2.0.2 then. If there is anything else still pending I'd pr

Re: [S2] Struts 2.0.2 Build - ON HOLD

I don't know - you are the one that wrote the patch :) If we need to break the new ajax tag to keep backward compatibility for the 2.0.2 release, I can live with it. Are there any examples in the showcase that would be broken if we reverted the anchor tag behavior? Don Musachy Barroso wrote

Re: [S2] Struts 2.0.2 Build - ON HOLD

The problem is that for the ajax stuff it needs "buildUrl" to generate the right url, is there anything we can do to keep them both working? musachy On 12/4/06, Don Brown <[EMAIL PROTECTED]> wrote: Musachy Barroso wrote: > Before the anchor tag was processing the href attribute like this: > >

Re: [S2] Struts 2.0.2 Build - ON HOLD

Musachy Barroso wrote: Before the anchor tag was processing the href attribute like this: addParameter("href", findString(href)); after the changes for the ajax tags, they are all processing the href like this: addParameter("href", UrlHelper.buildUrl(findString(href), request, response, nu

Re: [S2] Struts 2.0.2 Build - ON HOLD

And 3 seconds later :) The anchor is just using the url(duh), so it is processing it again. musachy Musachy Barroso wrote: Before the anchor tag was processing the href attribute like this: addParameter("href", findString(href)); after the changes for the ajax tags, they are all processi

Re: [S2] Struts 2.0.2 Build - ON HOLD

Before the anchor tag was processing the href attribute like this: addParameter("href", findString(href)); after the changes for the ajax tags, they are all processing the href like this: addParameter("href", UrlHelper.buildUrl(findString(href), request, response, null)); but I can't figu

Re: [S2] Struts 2.0.2 Build - ON HOLD

From what I can tell, the recent patch WW-1485 broke, or at least changed, the anchor tag. The url is being generated correctly, however, the anchor tag is incorrectly processing the url a second time. Rainer applied the patch, so perhaps he might know how to fix it? Don Ted Husted wrote:

Re: [S2] Struts 2.0.2 Build - ON HOLD

I just filed * https://issues.apache.org/struts/browse/WW-1537 Links in the showcase that refer to namespaces are rendering the webapp root twice. * http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/ The problem