Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-06-01 Thread Greg Huber
Works great for me, good job everyone. +1 On Wed, 1 Jun 2022 at 18:57, Lukasz Lenart wrote: > Are we good to go? > > śr., 25 maj 2022 o 18:42 Lukasz Lenart > napisał(a): > > > > I would suggest moving this expression into Java code, into "bean" - > > this is then easy to cover with a unit test.

Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-06-01 Thread Lukasz Lenart
Are we good to go? śr., 25 maj 2022 o 18:42 Lukasz Lenart napisał(a): > > I would suggest moving this expression into Java code, into "bean" - > this is then easy to cover with a unit test. > > śr., 25 maj 2022 o 14:52 i...@flyingfischer.ch > napisał(a): > > > > Besides incrementing or disabling

Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-05-25 Thread Lukasz Lenart
I would suggest moving this expression into Java code, into "bean" - this is then easy to cover with a unit test. śr., 25 maj 2022 o 14:52 i...@flyingfischer.ch napisał(a): > > Besides incrementing or disabling this arbitrary limit with > > > > You may also work with a most ugly hack by defining

Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-05-25 Thread i...@flyingfischer.ch
Besides incrementing or disabling this arbitrary limit with You may also work with a most ugly hack by defining a variable in your jsp and then use this very short variables in your too long OGNL expression. Ugly, does add to code complexity and increases the overall failure rate.But may h

Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-05-25 Thread i...@flyingfischer.ch
You may use this in Struts.xml   You need to find you longest OGNL value, discipline yourself to shorten those, rethink you variable name length or disable this completly   Not that much of a convincing approach to improve security, but maybe better than not. I did not like it at all, but

Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-05-25 Thread Greg Huber
I will have others longer than this, is there an override on the length? On 25/05/2022 13:34, Lukasz Lenart wrote: śr., 25 maj 2022 o 14:22 Greg Huber napisał(a): Would there have been any changes to the validator? This is now not working: unspecified key

Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-05-25 Thread Lukasz Lenart
śr., 25 maj 2022 o 14:22 Greg Huber napisał(a): > > Would there have been any changes to the validator? > > This is now not working: > > > > unspecified > key > OGNL expression max length has been defined by default to 256 characters, the above has 351 https://issue

Re: [TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-05-25 Thread Greg Huber
Would there have been any changes to the validator? This is now not working:             unspecified key     It works on RC3. It is odd as the validator is still working on other fields. On 24/05/2022 13:25, Lukasz Lenart wrote: Hello, This is another RC (I hope the last one) o

[TEST] Struts 2 ver. 6.0.0-RC4 test build is ready

2022-05-24 Thread Lukasz Lenart
Hello, This is another RC (I hope the last one) of incoming Struts 6.x with tons of changes. Please take the time and test the bits - any help is appreciated. Please report any problems you will spot. Here are the changes from the previous RC version: https://github.com/apache/struts/releases/tag